2011-02-07 15:28:14

by John Villalovos

Subject: [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique

x86, apic: Make "broken BIOS!!" messages unique

There are five identical "broken BIOS!!" messages. This patch makes each
message unique so that it is easier to determine which message was actually
printed. Changed to "broken MPBIOS: <unique identifier>!!"

The 'inconceivable' messages are because it should not be possible to reach
those code paths.

V2: Change to specify MPBIOS and remove exclamation marks.

Signed-off-by: John L. Villalovos <[email protected]>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 697dc34..5391276 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -841,7 +841,7 @@ static int MPBIOS_polarity(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: polarity\n");
polarity = 1;
break;
}
@@ -852,7 +852,7 @@ static int MPBIOS_polarity(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: inconceivable polarity\n");
polarity = 1;
break;
}
@@ -899,7 +899,7 @@ static int MPBIOS_trigger(int idx)
}
default:
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: unknown bus type\n");
trigger = 1;
break;
}
@@ -913,7 +913,7 @@ static int MPBIOS_trigger(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: trigger\n");
trigger = 1;
break;
}
@@ -924,7 +924,7 @@ static int MPBIOS_trigger(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: inconceivable trigger\n");
trigger = 0;
break;
}

2011-02-07 21:26:21

by H. Peter Anvin

Subject: Re: [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique

On 02/07/2011 05:58 AM, John Villalovos wrote:
>
> The 'inconceivable' messages are because it should not be possible to reach
> those code paths.
>

More standard terminology would be "invalid" or "impossible".
"Inconceivable" sounds like a combination of legal values which just
don't make sense.

-hpa

2011-02-07 21:33:57

by John Villalovos

Subject: Re: [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique

On 02/07/2011 04:25 PM, H. Peter Anvin wrote:
> On 02/07/2011 05:58 AM, John Villalovos wrote:
>> The 'inconceivable' messages are because it should not be possible to reach
>> those code paths.
>>
> More standard terminology would be "invalid" or "impossible".
> "Inconceivable" sounds like a combination of legal values which just
> don't make sense.
To be honest I used it in homage to The Princess Bride movie. And
frankly it is 'inconcievable' that code will ever be called :)

John