2011-02-10 02:52:01

by jiaweiwei

[permalink] [raw]
Subject: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

Hi us,
When i see MAITAINERS, i find an inconsistent double-quotation-marks.
So i patch for it:) patcher like following.

Thanks.
Best Regards.
Harry Wei.


Signed-off-by: Harry Wei <[email protected]>
---
MAINTAINERS | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index afb6f7c..95ac55c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -139,7 +139,7 @@ S: Supported
F: drivers/scsi/3w-*

53C700 AND 53C700-66 SCSI DRIVER
-M: "James E.J. Bottomley" <[email protected]>
+M: James E.J. Bottomley <[email protected]>
L: [email protected]
S: Maintained
F: drivers/scsi/53c700*
--
1.7.0.4


2011-02-10 03:04:46

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

On Thu, Feb 10, 2011 at 10:51:35AM +0800, Harry Wei wrote:
> Hi us,
> When i see MAITAINERS, i find an inconsistent double-quotation-marks.
> So i patch for it:) patcher like following.

The quotes are there to handle the '.' character which email clients
need. If you have a question about a specific person's entry, why not
email them about it? To not do so is a bit rude.

thanks,

greg k-h

2011-02-10 03:06:38

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

On Thu, 10 Feb 2011 10:51:35 +0800 Harry Wei <[email protected]> wrote:

> Hi us,
> When i see MAITAINERS, i find an inconsistent double-quotation-marks.
> So i patch for it:) patcher like following.
>
> Thanks.
> Best Regards.
> Harry Wei.
>
>
> Signed-off-by: Harry Wei <[email protected]>
> ---
> MAINTAINERS | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index afb6f7c..95ac55c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -139,7 +139,7 @@ S: Supported
> F: drivers/scsi/3w-*
>
> 53C700 AND 53C700-66 SCSI DRIVER
> -M: "James E.J. Bottomley" <[email protected]>
> +M: James E.J. Bottomley <[email protected]>
> L: [email protected]
> S: Maintained
> F: drivers/scsi/53c700*

I suspect that some mail clients will explode if you provide them with
an unquoted string containing periods. That would make copy-n-paste
rather a hassle.

2011-02-10 03:17:19

by David Miller

[permalink] [raw]
Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

From: Andrew Morton <[email protected]>
Date: Wed, 9 Feb 2011 19:06:31 -0800

> I suspect that some mail clients will explode if you provide them with
> an unquoted string containing periods. That would make copy-n-paste
> rather a hassle.

It's not clients, it's servers.

SMTP rules state that characters such as "." cannot appear
unquoted in email headers.

vger.kernel.org rejects mail when this violation occurs.

2011-02-19 16:49:08

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

On Wed 2011-02-09 19:17:52, David Miller wrote:
> From: Andrew Morton <[email protected]>
> Date: Wed, 9 Feb 2011 19:06:31 -0800
>
> > I suspect that some mail clients will explode if you provide them with
> > an unquoted string containing periods. That would make copy-n-paste
> > rather a hassle.
>
> It's not clients, it's servers.
>
> SMTP rules state that characters such as "." cannot appear
> unquoted in email headers.
>
> vger.kernel.org rejects mail when this violation occurs.

Ok, but should not MUA do this quotation? Quick test shows that mutt does...

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2011-02-19 21:59:53

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> On Wed 2011-02-09 19:17:52, David Miller wrote:
> > From: Andrew Morton <[email protected]>
> > > I suspect that some mail clients will explode if you provide them with
> > > an unquoted string containing periods. That would make copy-n-paste
> > > rather a hassle.
> > It's not clients, it's servers.
> > SMTP rules state that characters such as "." cannot appear
> > unquoted in email headers.
> > vger.kernel.org rejects mail when this violation occurs.
> Ok, but should not MUA do this quotation? Quick test shows that mutt does...

My recollection is that the get_maintainer script
cannot parse M: lines with multiple entries with
periods without the quotes.

M: First I. Last <[email protected]>, Last.I.First <[email protected]>

fails and

M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>

succeeds.

You are welcome to improve the parsing in that routine.

2011-02-22 09:28:42

by Florian Mickler

[permalink] [raw]
Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

On Sat, 19 Feb 2011 13:59:50 -0800
Joe Perches <[email protected]> wrote:

> On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > From: Andrew Morton <[email protected]>
> > > > I suspect that some mail clients will explode if you provide them with
> > > > an unquoted string containing periods. That would make copy-n-paste
> > > > rather a hassle.
> > > It's not clients, it's servers.
> > > SMTP rules state that characters such as "." cannot appear
> > > unquoted in email headers.
> > > vger.kernel.org rejects mail when this violation occurs.
> > Ok, but should not MUA do this quotation? Quick test shows that mutt does...
>
> My recollection is that the get_maintainer script
> cannot parse M: lines with multiple entries with
> periods without the quotes.
>
> M: First I. Last <[email protected]>, Last.I.First <[email protected]>
>
> fails and
>
> M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
>
> succeeds.
>
> You are welcome to improve the parsing in that routine.
>

There are perl modules providing full rfc parsing of email addresses
(with all those weird cases nobody uses) ... but i doubt it's urgent,
especially as we can more or less control the input to get_maintainer.pl
by controlling the MAINTAINER file and the git version history ...