Hi us,
I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position.
Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.
Thanks.
Best Regards.
Harry Wei.
On Fri, Feb 11, 2011 at 08:29:28PM +0800, Harry Wei wrote:
> Hi us,
> I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position.
> Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
> I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.
Why not just modify the 'scripts/get_maintainers.pl' tool to do this?
thanks,
greg k-h
On Fri, 11 Feb 2011 07:40:14 -0800
Greg KH <[email protected]> wrote:
> On Fri, Feb 11, 2011 at 08:29:28PM +0800, Harry Wei wrote:
> > Hi us,
> > I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position.
> > Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
> > I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.
>
> Why not just modify the 'scripts/get_maintainers.pl' tool to do this?
>
> thanks,
>
> greg k-h
surely, you mean hooking it into 'scripts/checkpatch.pl' ?
On Fri, Feb 11, 2011 at 10:14:33PM +0100, Florian Mickler wrote:
> On Fri, 11 Feb 2011 07:40:14 -0800
> Greg KH <[email protected]> wrote:
>
> > On Fri, Feb 11, 2011 at 08:29:28PM +0800, Harry Wei wrote:
> > > Hi us,
> > > I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position.
> > > Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
> > > I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.
> >
> > Why not just modify the 'scripts/get_maintainers.pl' tool to do this?
> >
> > thanks,
> >
> > greg k-h
>
> surely, you mean hooking it into 'scripts/checkpatch.pl' ?
>
No, I hadn't ment that, as I figured get_maintainers.pl already parsed
the MAINTAINERS file, so it might be easier to do it there.
But you are probably right, it's only an issue when you add a
MAINTAINERS entry, so it should go into that script.
Although I'm really loath to add any more to that script, it's slow
enough as it is on large patches :(
thanks,
greg k-h
On Fri, 11 Feb 2011 13:25:54 -0800
Greg KH <[email protected]> wrote:
> On Fri, Feb 11, 2011 at 10:14:33PM +0100, Florian Mickler wrote:
> > On Fri, 11 Feb 2011 07:40:14 -0800
> > Greg KH <[email protected]> wrote:
> >
> > > On Fri, Feb 11, 2011 at 08:29:28PM +0800, Harry Wei wrote:
> > > > Hi us,
> > > > I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position.
> > > > Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
> > > > I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.
> > >
> > > Why not just modify the 'scripts/get_maintainers.pl' tool to do this?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > surely, you mean hooking it into 'scripts/checkpatch.pl' ?
> >
>
> No, I hadn't ment that, as I figured get_maintainers.pl already parsed
> the MAINTAINERS file, so it might be easier to do it there.
perl -e '$last = "0"; while (<>) { @F = split(/:/); if ($begin) { if (!/^\s*$/ && length($F[0]) > 1) { unless ($last le $_) { print "header wrongly sorted! ($_)\n"; $err =1; } $last = $_; }}; $begin = 1 if ( $F[0] =~ /\t\t-----------------------------------$/);} exit(1) if ($err); ' < MAINTAINERS
:)
Regards,
Flo