2011-02-14 10:54:37

by Vasily Kulikov

Subject: [PATCH] bluethooth: sco: fix information leak to userspace

struct sco_conninfo has one padding byte in the end. Local variable
cinfo of type sco_conninfo is copied to userspace with this uninizialized
one byte, leading to old stack contents leak.

Signed-off-by: Vasiliy Kulikov <[email protected]>
---
Compile tested.

net/bluetooth/sco.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 960c6d1..926ed39 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -703,6 +703,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user
break;
}

+ memset(&cinfo, 0, sizeof(cinfo));
cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle;
memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);

--
1.7.0.4

2011-02-14 14:36:22

by Gustavo Padovan

Subject: Re: [PATCH] bluethooth: sco: fix information leak to userspace

Hi Vasiliy,

* Vasiliy Kulikov <[email protected]> [2011-02-14 13:54:26 +0300]:

> struct sco_conninfo has one padding byte in the end. Local variable
> cinfo of type sco_conninfo is copied to userspace with this uninizialized
> one byte, leading to old stack contents leak.
>
> Signed-off-by: Vasiliy Kulikov <[email protected]>
> ---
> Compile tested.
>
> net/bluetooth/sco.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Applied as well, thanks.

--
Gustavo F. Padovan
http://profusion.mobi