On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> ---------- Forwarded message ----------
> From: Joe Perches <[email protected]>
> Date: 2011/2/20
> Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS
> consistent
> To: Pavel Machek <[email protected]>
> Cc: David Miller <[email protected]>, [email protected],
> [email protected], [email protected], [email protected],
> [email protected]
>
>
> On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > From: Andrew Morton <[email protected]>
> > > > I suspect that some mail clients will explode if you provide them with
> > > > an unquoted string containing periods. That would make copy-n-paste
> > > > rather a hassle.
> > > It's not clients, it's servers.
> > > SMTP rules state that characters such as "." cannot appear
> > > unquoted in email headers.
> > > vger.kernel.org rejects mail when this violation occurs.
> > Ok, but should not MUA do this quotation? Quick test shows that mutt
> does...
>
> My recollection is that the get_maintainer script
> cannot parse M: lines with multiple entries with
> periods without the quotes.
>
> M: First I. Last <[email protected]>, Last.I.First <[email protected]>
>
> fails and
>
> M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
>
> succeeds.
>
> You are welcome to improve the parsing in that routine.
Hi Joe,
In order to improve the parsing in that routine we should remove all the the double-quotation-marks in the MAINTAINERS ? Maybe we have other better ways? Tell me and i will patch for us.
Like the Greg K-H said, we should firstly notify the maintainers who have the double-quotation-marks in their M:. Then we can make this patch :)
Thanks.
Best Regards.
Harry Wei.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Best Regards.
> Harry Wei.
> Do what u like!
Add quotes around email address with periods and commas.
Signed-off-by: Joe Perches <[email protected]>
---
On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote:
> On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> > From: Joe Perches <[email protected]>
> > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > > From: Andrew Morton <[email protected]>
> > > > > I suspect that some mail clients will explode if you provide them with
> > > > > an unquoted string containing periods. That would make copy-n-paste
> > > > > rather a hassle.
> > > > It's not clients, it's servers.
> > > > SMTP rules state that characters such as "." cannot appear
> > > > unquoted in email headers.
> > > > vger.kernel.org rejects mail when this violation occurs.
> > > Ok, but should not MUA do this quotation? Quick test shows that mutt
> > does...
> > My recollection is that the get_maintainer script
> > cannot parse M: lines with multiple entries with
> > periods without the quotes.
> > M: First I. Last <[email protected]>, Last.I.First <[email protected]>
> > fails and
> > M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
> > succeeds.
> > You are welcome to improve the parsing in that routine.
> In order to improve the parsing in that routine we should remove all
> the the double-quotation-marks in the MAINTAINERS ?
No, that'd be wrong before improving parsing and
verifying that all currently used client/MUAs work
without quotes.
> Maybe we have other better ways? Tell me and i will patch for us.
I think leaving the quotes is the right thing to do.
Quoting names that have non alphanumeric
characters before any open angle bracket '<'
is better than remove quotes.
MAINTAINERS | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e45eabe..af586f8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1044,7 +1044,7 @@ L: [email protected] (moderated for non-subscribers)
S: Maintained
ARM/TETON BGA MACHINE SUPPORT
-M: Mark F. Brown <[email protected]>
+M: "Mark F. Brown" <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Maintained
@@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c
BLUETOOTH DRIVERS
M: Marcel Holtmann <[email protected]>
-M: Gustavo F. Padovan <[email protected]>
+M: "Gustavo F. Padovan" <[email protected]>
L: [email protected]
W: http://www.bluez.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
@@ -1457,7 +1457,7 @@ F: drivers/bluetooth/
BLUETOOTH SUBSYSTEM
M: Marcel Holtmann <[email protected]>
-M: Gustavo F. Padovan <[email protected]>
+M: "Gustavo F. Padovan" <[email protected]>
L: [email protected]
W: http://www.bluez.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
@@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt
F: drivers/block/cpqarray.*
HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)
-M: Stephen M. Cameron <[email protected]>
+M: "Stephen M. Cameron" <[email protected]>
L: [email protected]
S: Supported
F: Documentation/scsi/hpsa.txt
@@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio
F: drivers/char/mxser.*
MSI LAPTOP SUPPORT
-M: Lee, Chun-Yi <[email protected]>
+M: "Lee, Chun-Yi" <[email protected]>
L: [email protected]
S: Maintained
F: drivers/platform/x86/msi-laptop.c
On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> Add quotes around email address with periods and commas.
>
> Signed-off-by: Joe Perches <[email protected]>
Acked-by: Harry Wei <[email protected]>
But i think you should also tell the maintainers
you add quotes for their M: in the MAINTAINERS.
> ---
> On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote:
> > On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> > > From: Joe Perches <[email protected]>
> > > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > > > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > > > From: Andrew Morton <[email protected]>
> > > > > > I suspect that some mail clients will explode if you provide them with
> > > > > > an unquoted string containing periods. That would make copy-n-paste
> > > > > > rather a hassle.
> > > > > It's not clients, it's servers.
> > > > > SMTP rules state that characters such as "." cannot appear
> > > > > unquoted in email headers.
> > > > > vger.kernel.org rejects mail when this violation occurs.
> > > > Ok, but should not MUA do this quotation? Quick test shows that mutt
> > > does...
> > > My recollection is that the get_maintainer script
> > > cannot parse M: lines with multiple entries with
> > > periods without the quotes.
> > > M: First I. Last <[email protected]>, Last.I.First <[email protected]>
> > > fails and
> > > M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
> > > succeeds.
> > > You are welcome to improve the parsing in that routine.
> > In order to improve the parsing in that routine we should remove all
> > the the double-quotation-marks in the MAINTAINERS ?
>
> No, that'd be wrong before improving parsing and
> verifying that all currently used client/MUAs work
> without quotes.
>
> > Maybe we have other better ways? Tell me and i will patch for us.
>
> I think leaving the quotes is the right thing to do.
>
> Quoting names that have non alphanumeric
> characters before any open angle bracket '<'
> is better than remove quotes.
>
> MAINTAINERS | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e45eabe..af586f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1044,7 +1044,7 @@ L: [email protected] (moderated for non-subscribers)
> S: Maintained
>
> ARM/TETON BGA MACHINE SUPPORT
> -M: Mark F. Brown <[email protected]>
> +M: "Mark F. Brown" <[email protected]>
> L: [email protected] (moderated for non-subscribers)
> S: Maintained
>
> @@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c
>
> BLUETOOTH DRIVERS
> M: Marcel Holtmann <[email protected]>
> -M: Gustavo F. Padovan <[email protected]>
> +M: "Gustavo F. Padovan" <[email protected]>
> L: [email protected]
> W: http://www.bluez.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -1457,7 +1457,7 @@ F: drivers/bluetooth/
>
> BLUETOOTH SUBSYSTEM
> M: Marcel Holtmann <[email protected]>
> -M: Gustavo F. Padovan <[email protected]>
> +M: "Gustavo F. Padovan" <[email protected]>
> L: [email protected]
> W: http://www.bluez.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt
> F: drivers/block/cpqarray.*
>
> HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)
> -M: Stephen M. Cameron <[email protected]>
> +M: "Stephen M. Cameron" <[email protected]>
> L: [email protected]
> S: Supported
> F: Documentation/scsi/hpsa.txt
> @@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio
> F: drivers/char/mxser.*
>
> MSI LAPTOP SUPPORT
> -M: Lee, Chun-Yi <[email protected]>
> +M: "Lee, Chun-Yi" <[email protected]>
> L: [email protected]
> S: Maintained
> F: drivers/platform/x86/msi-laptop.c
>
>
On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> Add quotes around email address with periods and commas.
>
> Signed-off-by: Joe Perches <[email protected]>
> ---
> On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote:
> > On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> > > From: Joe Perches <[email protected]>
> > > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > > > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > > > From: Andrew Morton <[email protected]>
> > > > > > I suspect that some mail clients will explode if you provide them with
> > > > > > an unquoted string containing periods. That would make copy-n-paste
> > > > > > rather a hassle.
> > > > > It's not clients, it's servers.
> > > > > SMTP rules state that characters such as "." cannot appear
> > > > > unquoted in email headers.
> > > > > vger.kernel.org rejects mail when this violation occurs.
> > > > Ok, but should not MUA do this quotation? Quick test shows that mutt
> > > does...
> > > My recollection is that the get_maintainer script
> > > cannot parse M: lines with multiple entries with
> > > periods without the quotes.
> > > M: First I. Last <[email protected]>, Last.I.First <[email protected]>
> > > fails and
> > > M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
> > > succeeds.
> > > You are welcome to improve the parsing in that routine.
> > In order to improve the parsing in that routine we should remove all
> > the the double-quotation-marks in the MAINTAINERS ?
>
> No, that'd be wrong before improving parsing and
> verifying that all currently used client/MUAs work
> without quotes.
>
> > Maybe we have other better ways? Tell me and i will patch for us.
>
> I think leaving the quotes is the right thing to do.
>
> Quoting names that have non alphanumeric
> characters before any open angle bracket '<'
> is better than remove quotes.
Hmm, what about some other conditions except
for periods and commas in maintainers' M:.
Like following:
1> Character '-' in M:
CALGARY x86-64 IOMMU
Muli Ben-Yehuda <[email protected]>
2> No name of the M:
M: [email protected]
3> Messy code in M:
M: Benoît Cousson <[email protected]>
Should we also patch for them?
Can client/MUAs work them well?
Thanks.
Best Regards.
Harry Wei.
>
> MAINTAINERS | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e45eabe..af586f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1044,7 +1044,7 @@ L: [email protected] (moderated for non-subscribers)
> S: Maintained
>
> ARM/TETON BGA MACHINE SUPPORT
> -M: Mark F. Brown <[email protected]>
> +M: "Mark F. Brown" <[email protected]>
> L: [email protected] (moderated for non-subscribers)
> S: Maintained
>
> @@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c
>
> BLUETOOTH DRIVERS
> M: Marcel Holtmann <[email protected]>
> -M: Gustavo F. Padovan <[email protected]>
> +M: "Gustavo F. Padovan" <[email protected]>
> L: [email protected]
> W: http://www.bluez.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -1457,7 +1457,7 @@ F: drivers/bluetooth/
>
> BLUETOOTH SUBSYSTEM
> M: Marcel Holtmann <[email protected]>
> -M: Gustavo F. Padovan <[email protected]>
> +M: "Gustavo F. Padovan" <[email protected]>
> L: [email protected]
> W: http://www.bluez.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt
> F: drivers/block/cpqarray.*
>
> HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)
> -M: Stephen M. Cameron <[email protected]>
> +M: "Stephen M. Cameron" <[email protected]>
> L: [email protected]
> S: Supported
> F: Documentation/scsi/hpsa.txt
> @@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio
> F: drivers/char/mxser.*
>
> MSI LAPTOP SUPPORT
> -M: Lee, Chun-Yi <[email protected]>
> +M: "Lee, Chun-Yi" <[email protected]>
> L: [email protected]
> S: Maintained
> F: drivers/platform/x86/msi-laptop.c
>
>
On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
> On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> > Add quotes around email address with periods and commas.
> Hmm, what about some other conditions except
> for periods and commas in maintainers' M:.
> Like following:
> 1> Character '-' in M:
Dashes are not an issue.
> 2> No name of the M:
> M: [email protected]
Names and angle brackets are optional.
> 3> Messy code in M:
> M: Benoît Cousson <[email protected]>
8 bit characters _might_ be an issue, but
no one has reported any problems yet.
I think you should read and understand rfc 2822
before continuing with this.
Utilities like git send-email and get_maintainer.pl
generally provide email address parsing for only a
subset of all valid address styles.
As these utilities are done mostly by regex, not
all valid email addresses are supported because the
regex validations get ridiculously complicated.
There are some "monster" regex classes that attempt
to support a greater range of valid email address
styles, but the pain of implementation generally
isn't worth it.
You're free to try to improve it of course, but I
think that modifications to the address styles
currently used in MAINTAINERS to remove "special"
address style handling isn't necessary.