2011-02-23 08:00:11

by J. R. Okajima

Subject: [PATCH] Unlock vfsmount_lock in do_mount

By the commit
b3e19d9 2011-01-07 fs: scale mntget/mntput
vfsmount_lock was introduced around testing mnt_count.
Fix the mis-typed 'unlock'

Signed-off-by: J. R. Okajima <[email protected]>
---
fs/namespace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 7b0b953..d1edf26 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1244,7 +1244,7 @@ static int do_umount(struct vfsmount *mnt, int flags)
*/
br_write_lock(vfsmount_lock);
if (mnt_get_count(mnt) != 2) {
- br_write_lock(vfsmount_lock);
+ br_write_unlock(vfsmount_lock);
return -EBUSY;
}
br_write_unlock(vfsmount_lock);
--
1.6.6.1

2011-02-24 01:11:04

by Al Viro

Subject: Re: [PATCH] Unlock vfsmount_lock in do_mount

On Wed, Feb 23, 2011 at 04:59:49PM +0900, J. R. Okajima wrote:
> By the commit
> b3e19d9 2011-01-07 fs: scale mntget/mntput
> vfsmount_lock was introduced around testing mnt_count.
> Fix the mis-typed 'unlock'

Gyah... Nice catch. Applied, will push tonight.

2011-02-24 04:11:13

by J. R. Okajima

Subject: Re: [PATCH] Unlock vfsmount_lock in do_mount

Al Viro:
> On Wed, Feb 23, 2011 at 04:59:49PM +0900, J. R. Okajima wrote:
> > By the commit
> > b3e19d9 2011-01-07 fs: scale mntget/mntput
> > vfsmount_lock was introduced around testing mnt_count.
> > Fix the mis-typed 'unlock'
>
> Gyah... Nice catch. Applied, will push tonight.

Thanks.
But I made a mistake in the subject.
It should be "do_umount" instead of "do_mount". Please fix it when you
push. Otherwise I will post the fixed one.


J. R. Okajima