2011-02-23 21:07:54

by Moffett, Kyle D

Subject: mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"

Hello everyone,

I just started trying to update some patches for our P2020-based unit to the latest Linus upstream, hoping to take advantage of the recent mpc85xx kexec() support.

Unfortunately I'm getting a compile error:

arch/powerpc/platforms/85xx/smp.c:241: error: 'struct machdep_calls' has no member named 'machine_kexec'

As far as I can tell, "machine_kexec" was removed in commit c9486878 (powerpc/kexec: Remove ppc_md.machine_kexec) on Jan 6th, 2011, which claims that it was not used.

Unfortunately it looks like it *is* used by the mpc85xx kexec() support (commit f933a41e), added on Jul 21, 2010.

Cheers,
Kyle Moffett

2011-02-23 22:11:27

by Anton Blanchard

Subject: Re: mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"

Hi Kyle,

> As far as I can tell, "machine_kexec" was removed in commit c9486878
> (powerpc/kexec: Remove ppc_md.machine_kexec) on Jan 6th, 2011, which
> claims that it was not used.
>
> Unfortunately it looks like it *is* used by the mpc85xx kexec()
> support (commit f933a41e), added on Jul 21, 2010.

Thanks for the report. Testing a patch now.

Anton