This is a set of 5 patches to enable kernel crypto operation of the
SEP device
All patches are required as a set.
Signed-off-by: Mark Allyn <[email protected]>
On Sun, Feb 27, 2011 at 09:10:24PM -0800, Mark Allyn wrote:
> This is a set of 5 patches to enable kernel crypto operation of the
> SEP device
>
> All patches are required as a set.
>
> Signed-off-by: Mark Allyn <[email protected]>
Is this really a "request for comments" set of patches, or do you want
me to apply them to my tree?
confused,
greg k-h
Is this really a "request for comments" set of patches, or do you want
me to apply them to my tree?
confused,
greg k-h
Greg:
This was meant to be request for comment so that I can make any necessary
Changes prior to submitting it for the tree.
Mark
On Sun, Feb 27, 2011 at 09:10:24PM -0800, Mark Allyn wrote:
> This is a set of 5 patches to enable kernel crypto operation of the
> SEP device
Why? What does this mean to me? To users? You need to sell this new
feature to me a LOT before I will take it as I really want and need to
see this driver fixed up first before you can add new features to it.
thanks,
greg k-h
Greg writes:
Why? What does this mean to me? To users? You need to sell this new
feature to me a LOT before I will take it as I really want and need to
see this driver fixed up first before you can add new features to it.
thanks,
greg k-h
=================
Greg:
I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.
What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
What other issues are there?
Thanks
Mark Allyn
On Tue, Mar 01, 2011 at 02:10:09PM -0700, Allyn, Mark A wrote:
> Greg writes:
>
> Why? What does this mean to me? To users? You need to sell this new
> feature to me a LOT before I will take it as I really want and need to
> see this driver fixed up first before you can add new features to it.
>
> thanks,
>
> greg k-h
>
>
> =================
>
> Greg:
>
> I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.
First off, please fix your email client to do proper quoting and wrap
lines at 72 columns. Even Outlook can do this so there really is no
excuse anymore...
>
> What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
>
> What other issues are there?
That's a good place to start, fix those up and when you feel you have
addressed everything, ask for a review of the code and we can go from
there.
thanks,
greg k-h