2011-03-01 19:18:52

by Ondrej Zary

[permalink] [raw]
Subject: [PATCH 5/5] s3fb: use new start address register

Use "new" start address register 0x69 (bits 16-20) instead of "old" 0x31
(bits 16-17) and 0x51 (bits 18-19). This is needed for panning to work
correctly on Trio3D/2X cards (and does no harm on other ones).

Signed-off-by: Ondrej Zary <[email protected]>

--- linux-2.6.38-rc4-/drivers/video/s3fb.c 2011-03-01 18:38:58.000000000 +0100
+++ linux-2.6.38-rc4/drivers/video/s3fb.c 2011-03-01 18:39:35.000000000 +0100
@@ -123,7 +123,7 @@ static const struct vga_regset s3_v_sync
static const struct vga_regset s3_v_sync_end_regs[] = {{0x11, 0, 3}, VGA_REGSET_END};

static const struct vga_regset s3_line_compare_regs[] = {{0x18, 0, 7}, {0x07, 4, 4}, {0x09, 6, 6}, {0x5E, 6, 6}, VGA_REGSET_END};
-static const struct vga_regset s3_start_address_regs[] = {{0x0d, 0, 7}, {0x0c, 0, 7}, {0x31, 4, 5}, {0x51, 0, 1}, VGA_REGSET_END};
+static const struct vga_regset s3_start_address_regs[] = {{0x0d, 0, 7}, {0x0c, 0, 7}, {0x69, 0, 4}, VGA_REGSET_END};
static const struct vga_regset s3_offset_regs[] = {{0x13, 0, 7}, {0x51, 4, 5}, VGA_REGSET_END}; /* set 0x43 bit 2 to 0 */

static const struct vga_regset s3_dtpc_regs[] = {{0x3B, 0, 7}, {0x5D, 6, 6}, VGA_REGSET_END};

--
Ondrej Zary


2011-03-03 09:29:46

by Ondrej Zajicek

[permalink] [raw]
Subject: Re: [PATCH 5/5] s3fb: use new start address register

On Tue, Mar 01, 2011 at 08:18:43PM +0100, Ondrej Zary wrote:
> Use "new" start address register 0x69 (bits 16-20) instead of "old" 0x31
> (bits 16-17) and 0x51 (bits 18-19). This is needed for panning to work
> correctly on Trio3D/2X cards (and does no harm on other ones).
>
> Signed-off-by: Ondrej Zary <[email protected]>

Acked-by: Ondrej Zajicek <[email protected]>

--
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: [email protected])
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."


Attachments:
(No filename) (615.00 B)
signature.asc (197.00 B)
Digital signature
Download all attachments