2011-03-10 17:20:37

by j223yang

Subject: [Patch]ariadne: remove redundant NULL check

Simply remove redundant 'dev' NULL check.

Signed-off-by: Jinqiu Yang<[email protected]>
---
ariadne.c | 5 -----
1 file changed, 5 deletions(-)

--- a/drivers/net/ariadne.c 2011-03-10 11:20:14.076039323 -0500
+++ b/drivers/net/ariadne.c 2011-03-10 11:21:59.111164537 -0500
@@ -425,11 +425,6 @@ static irqreturn_t ariadne_interrupt(int
int csr0, boguscnt;
int handled = 0;

- if (dev == NULL) {
- printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n");
- return IRQ_NONE;
- }
-
lance->RAP = CSR0; /* PCnet-ISA Controller Status */

if (!(lance->RDP & INTR)) /* Check if any interrupt has been */

2011-03-10 22:12:21

by David Miller

Subject: Re: [Patch]ariadne: remove redundant NULL check

From: [email protected]
Date: Thu, 10 Mar 2011 12:20:31 -0500

> Simply remove redundant 'dev' NULL check.
>
> Signed-off-by: Jinqiu Yang<[email protected]>

This patch was corrupted by your email client, it turned TAB
characters into spaces which makes the patch unusable.

Also your signoff is badly formed, a space is missing between
your name and the "<" that begins your email address.