2011-03-18 08:26:10

by Mike Frysinger

Subject: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
the end leading to the build warning:
drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function

CC: [email protected]
Signed-off-by: Mike Frysinger <[email protected]>
---
drivers/rtc/rtc-bfin.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
index 17971d9..0e61e2d 100644
--- a/drivers/rtc/rtc-bfin.c
+++ b/drivers/rtc/rtc-bfin.c
@@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
bfin_rtc_int_set_alarm(rtc);
else
bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY));
+
+ return 0;
}

static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)
--
1.7.4.1

2011-03-18 14:26:44

by jiaweiwei

Subject: Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
> the end leading to the build warning:
> drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
> drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
Hi Mike,
I am sure we should give a return-value
but whether it is '0'? Maybe it should return
other value.
Can you give some explanations for yours.

Thanks.
Best Regards.
Harry Wei.
>
> CC: [email protected]
> Signed-off-by: Mike Frysinger <[email protected]>
> ---
> drivers/rtc/rtc-bfin.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
> index 17971d9..0e61e2d 100644
> --- a/drivers/rtc/rtc-bfin.c
> +++ b/drivers/rtc/rtc-bfin.c
> @@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
> bfin_rtc_int_set_alarm(rtc);
> else
> bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY));
> +
> + return 0;
> }
>
> static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2011-03-18 17:52:56

by Mike Frysinger

Subject: Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

On Fri, Mar 18, 2011 at 10:26, Harry Wei wrote:
> On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
>> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
>> the end leading to the build warning:
>>       drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
>>       drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
>
>   I am sure we should give a return-value
> but whether it is '0'? Maybe it should return
> other value.
>   Can you give some explanations for yours.

read the interface.c code ... this func returns 0 on "success". i
dont know what other possible value this could return.
-mike

2011-03-19 01:18:21

by John Stultz

Subject: Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

On Fri, 2011-03-18 at 04:26 -0400, Mike Frysinger wrote:
> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
> the end leading to the build warning:
> drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
> drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
>
> CC: [email protected]
> Signed-off-by: Mike Frysinger <[email protected]>

Thanks for catching this!

Acked-by: John Stultz <[email protected]>