2011-03-24 13:56:58

by Matt Fleming

Subject: [PATCH] dlm: Remove superfluous call to recalc_sigpending()

From: Matt Fleming <[email protected]>

recalc_sigpending() is called within sigprocmask(), so there is no
need call it again after sigprocmask() has returned.

Signed-off-by: Matt Fleming <[email protected]>
---
fs/dlm/user.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index 66d6c16..d9da93c 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -632,7 +632,6 @@ static ssize_t device_write(struct file *file, const char __user *buf,

out_sig:
sigprocmask(SIG_SETMASK, &tmpsig, NULL);
- recalc_sigpending();
out_free:
kfree(kbuf);
return error;
--
1.7.4

2011-03-28 15:23:40

by David Teigland

Subject: Re: [PATCH] dlm: Remove superfluous call to recalc_sigpending()

On Thu, Mar 24, 2011 at 01:56:47PM +0000, Matt Fleming wrote:
> From: Matt Fleming <[email protected]>
>
> recalc_sigpending() is called within sigprocmask(), so there is no
> need call it again after sigprocmask() has returned.

Thanks, pushed to dlm.git next.
Dave