2011-04-04 09:33:40

by Wanlong Gao

Subject: [PATCH] X86:NET:Replaced a deprecated function .

From: Wanlong Gao <[email protected]>

kernel_warning: pcmcia_request_exclusive_irq is deprecated .

Signed-off-by: Wanlong Gao <[email protected]>
---
drivers/net/pcmcia/nmclan_cs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c
index 76683d9..bf97231
--- a/drivers/net/pcmcia/nmclan_cs.c
+++ b/drivers/net/pcmcia/nmclan_cs.c
@@ -625,7 +625,7 @@ static int nmclan_config(struct pcmcia_device *link)
ret = pcmcia_request_io(link);
if (ret)
goto failed;
- ret = pcmcia_request_exclusive_irq(link, mace_interrupt);
+ ret = __pcmcia_request_exclusive_irq(link, mace_interrupt);
if (ret)
goto failed;
ret = pcmcia_enable_device(link);
--
1.7.3

2011-04-04 09:36:23

by Dominik Brodowski

Subject: Re: [PATCH] X86:NET:Replaced a deprecated function .

On Mon, Apr 04, 2011 at 05:32:28PM +0800, [email protected] wrote:
> From: Wanlong Gao <[email protected]>
>
> kernel_warning: pcmcia_request_exclusive_irq is deprecated .

NACK. This papers over the issue, instead of fixing it. To properly fix it,
one needs to verify that the IRQ handler used in this driver is capable of
handling a shared IRQ line.

Best,
Dominik

> Signed-off-by: Wanlong Gao <[email protected]>
> ---
> drivers/net/pcmcia/nmclan_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c
> index 76683d9..bf97231
> --- a/drivers/net/pcmcia/nmclan_cs.c
> +++ b/drivers/net/pcmcia/nmclan_cs.c
> @@ -625,7 +625,7 @@ static int nmclan_config(struct pcmcia_device *link)
> ret = pcmcia_request_io(link);
> if (ret)
> goto failed;
> - ret = pcmcia_request_exclusive_irq(link, mace_interrupt);
> + ret = __pcmcia_request_exclusive_irq(link, mace_interrupt);
> if (ret)
> goto failed;
> ret = pcmcia_enable_device(link);
> --
> 1.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2011-04-04 09:44:12

by Wanlong Gao

Subject: Re: Re: [PATCH] X86:NET:Replaced a deprecated function .

You means that some drivers still not capable of IRQF_SHARED?

Thanks

2011-04-04 09:53:27

by Dominik Brodowski

Subject: Re: Re: [PATCH] X86:NET:Replaced a deprecated function .

On Mon, Apr 04, 2011 at 05:44:00PM +0800, wanlong.gao wrote:
> You means that some drivers still not capable of IRQF_SHARED?

That's the issue. I do not know whether this driver is capable of
IRQF_SHARED as it should be. If it is, you may replace the
pcmcia_request_exclusive_irq() with pcmcia_request_irq(), and the warning
will be gone.

Best,
Dominik

2011-04-04 10:05:46

by Wanlong Gao

Subject: Re: Re: Re: [PATCH] X86:NET:Replaced a deprecated function .

I see the issue , but it is sorry that I don't know whether it is capable, yes .
So just ignore my stupid patch .

Thanks for your comments, and benefited a lot.