2011-04-05 15:01:25

by Michal Marek

[permalink] [raw]
Subject: [PATCH 25/34] usb/ftdi-elan: Drop __TIME__ usage

The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Cc: Tony Olech <[email protected]>
Cc: [email protected]
Signed-off-by: Michal Marek <[email protected]>
---
drivers/usb/misc/ftdi-elan.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
index 7839c98..b16bd3c 100644
--- a/drivers/usb/misc/ftdi-elan.c
+++ b/drivers/usb/misc/ftdi-elan.c
@@ -2889,8 +2889,7 @@ static struct usb_driver ftdi_elan_driver = {
static int __init ftdi_elan_init(void)
{
int result;
- printk(KERN_INFO "driver %s built at %s on %s\n", ftdi_elan_driver.name,
- __TIME__, __DATE__);
+ printk(KERN_INFO "driver %s\n", ftdi_elan_driver.name);
mutex_init(&ftdi_module_lock);
INIT_LIST_HEAD(&ftdi_static_list);
status_queue = create_singlethread_workqueue("ftdi-status-control");
--
1.7.4.1


2011-04-05 18:08:05

by Matthew Dharm

[permalink] [raw]
Subject: Re: [PATCH 25/34] usb/ftdi-elan: Drop __TIME__ usage

On Tue, Apr 05, 2011 at 04:59:12PM +0200, Michal Marek wrote:
> The kernel already prints its build timestamp during boot, no need to
> repeat it in random drivers and produce different object files each
> time.

What about drivers built as modules, which may be compiled at a different
time than the rest of the kernel?

Matt

--
Matthew Dharm Home: [email protected]
Maintainer, Linux USB Mass Storage Driver

Why am I talking to a toilet brush?
-- CEO
User Friendly, 4/30/1998


Attachments:
(No filename) (528.00 B)
(No filename) (189.00 B)
Download all attachments

2011-04-05 18:17:26

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 25/34] usb/ftdi-elan: Drop __TIME__ usage

On Tue, Apr 05, 2011 at 10:50:10AM -0700, Matthew Dharm wrote:
> On Tue, Apr 05, 2011 at 04:59:12PM +0200, Michal Marek wrote:
> > The kernel already prints its build timestamp during boot, no need to
> > repeat it in random drivers and produce different object files each
> > time.
>
> What about drivers built as modules, which may be compiled at a different
> time than the rest of the kernel?

We don't care :)

thanks,

greg k-h