2011-04-08 14:54:02

by Larry Finger

[permalink] [raw]
Subject: Removal of staging/rt2860sta (and rt2870sta)

Greg,

When I looked again at the removal of rt2860sta from staging, it was quickly
obvious that unless rt2870sta was also removed, very little of the code could be
removed. As I have no experience with rt2800usb, the mainline driver for that
device, I went to the wireless mailing list with the question. There was one
objection to the removal, but the maintainers were in favor, thus I will be
submitting a patch to delete both drivers.

I did the changes on my local git tree, committed them, and used 'git
format-patch'. I expected that 'git rm' statements would be used to delete the
files, but I got normal patch format. As a result, the resulting patch is over
2.4 GB, and has over 75,000 lines. Obviously, I'm reluctant to dump a patch of
this size on the lists. Is there a way to force git to use "rm" statements, or
is there some way to handle this large patch?

Thanks,

Larry


2011-04-08 16:13:22

by Greg KH

[permalink] [raw]
Subject: Re: Removal of staging/rt2860sta (and rt2870sta)

On Fri, Apr 08, 2011 at 09:53:57AM -0500, Larry Finger wrote:
> Greg,
>
> When I looked again at the removal of rt2860sta from staging, it was
> quickly obvious that unless rt2870sta was also removed, very little
> of the code could be removed. As I have no experience with
> rt2800usb, the mainline driver for that device, I went to the
> wireless mailing list with the question. There was one objection to
> the removal, but the maintainers were in favor, thus I will be
> submitting a patch to delete both drivers.
>
> I did the changes on my local git tree, committed them, and used
> 'git format-patch'. I expected that 'git rm' statements would be
> used to delete the files, but I got normal patch format. As a
> result, the resulting patch is over 2.4 GB, and has over 75,000
> lines. Obviously, I'm reluctant to dump a patch of this size on the
> lists. Is there a way to force git to use "rm" statements, or is
> there some way to handle this large patch?

You can point me at the git tree and I can pull from it :)

thanks,

greg k-h

2011-04-08 20:55:51

by Carlos R. Mafra

[permalink] [raw]
Subject: Re: Removal of staging/rt2860sta (and rt2870sta)

On Fri, 8 Apr 2011 at 9:53:57 -0500, Larry Finger wrote:
>
> I did the changes on my local git tree, committed them, and used
> 'git format-patch'. I expected that 'git rm' statements would be
> used to delete the files, but I got normal patch format. As a
> result, the resulting patch is over 2.4 GB, and has over 75,000
> lines. Obviously, I'm reluctant to dump a patch of this size on the
> lists. Is there a way to force git to use "rm" statements, or is
> there some way to handle this large patch?

I've just remembered about this patch in the git list, which I think
does what you want:

http://thread.gmane.org/gmane.comp.version-control.git/170537/focus=170581