2011-04-13 08:05:34

by Shaohua Li

Subject: [patch v2 2/4] percpu_counter: delete dead code

percpu_counter_sum_positive never returns negative.

Signed-off-by: Shaohua Li <[email protected]>

---
fs/ext4/balloc.c | 5 -----
1 file changed, 5 deletions(-)

Index: linux/fs/ext4/balloc.c
===================================================================
--- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
+++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
@@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
EXT4_FREEBLOCKS_WATERMARK) {
free_blocks = percpu_counter_sum_positive(fbc);
dirty_blocks = percpu_counter_sum_positive(dbc);
- if (dirty_blocks < 0) {
- printk(KERN_CRIT "Dirty block accounting "
- "went wrong %lld\n",
- (long long)dirty_blocks);
- }
}
/* Check whether we have space after
* accounting for current dirty blocks & root reserved blocks.

2011-04-13 18:59:35

by Tejun Heo

Subject: Re: [patch v2 2/4] percpu_counter: delete dead code

On Wed, Apr 13, 2011 at 03:57:17PM +0800, [email protected] wrote:
> percpu_counter_sum_positive never returns negative.
>
> Signed-off-by: Shaohua Li <[email protected]>

Can you please send this to ext4? - [email protected] and
"Theodore Ts'o" <[email protected]>.

Thanks.

--
tejun

2011-04-18 00:13:13

by Theodore Ts'o

Subject: Re: [patch v2 2/4] percpu_counter: delete dead code

I'll take care of merging this patch via the ext4 tree.

- Ted

On Wed, Apr 13, 2011 at 03:57:17PM +0800, [email protected] wrote:
> percpu_counter_sum_positive never returns negative.
>
> Signed-off-by: Shaohua Li <[email protected]>
>
> ---
> fs/ext4/balloc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> Index: linux/fs/ext4/balloc.c
> ===================================================================
> --- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
> +++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
> @@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
> EXT4_FREEBLOCKS_WATERMARK) {
> free_blocks = percpu_counter_sum_positive(fbc);
> dirty_blocks = percpu_counter_sum_positive(dbc);
> - if (dirty_blocks < 0) {
> - printk(KERN_CRIT "Dirty block accounting "
> - "went wrong %lld\n",
> - (long long)dirty_blocks);
> - }
> }
> /* Check whether we have space after
> * accounting for current dirty blocks & root reserved blocks.
>
>