2011-04-14 08:18:05

by Liu Yuan

Subject: [PATCH] video, udlfb: Fix two build warning about 'ignoring return value'

From: Liu Yuan <[email protected]>

Build warning:
...
drivers/video/udlfb.c:1590: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result
drivers/video/udlfb.c:1592: warning: ignoring return value of ‘device_create_bin_file’, declared with attribute warn_unused_result

So add two checks to get rid of 'em.

Signed-off-by: Liu Yuan <[email protected]>
---
drivers/video/udlfb.c | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index 68041d9..55d6de6 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -1586,10 +1586,19 @@ static int dlfb_usb_probe(struct usb_interface *interface,
goto error;
}

- for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++)
- device_create_file(info->dev, &fb_device_attrs[i]);
+ for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) {
+ retval = device_create_file(info->dev, &fb_device_attrs[i]);
+ if (retval) {
+ pr_err("device_create_file failed %d\n", retval);
+ goto error;
+ }
+ }

- device_create_bin_file(info->dev, &edid_attr);
+ retval = device_create_bin_file(info->dev, &edid_attr);
+ if (retval) {
+ pr_err("device_create_bin_file failed %d\n", retval);
+ goto error;
+ }

pr_info("DisplayLink USB device /dev/fb%d attached. %dx%d resolution."
" Using %dK framebuffer memory\n", info->node,
--
1.7.1

2011-04-18 08:46:45

by Paul Mundt

Subject: Re: [PATCH] video, udlfb: Fix two build warning about 'ignoring return value'

On Thu, Apr 14, 2011 at 04:17:50PM +0800, Liu Yuan wrote:
> Build warning:
> ...
> drivers/video/udlfb.c:1590: warning: ignoring return value of ???device_create_file???, declared with attribute warn_unused_result
> drivers/video/udlfb.c:1592: warning: ignoring return value of ???device_create_bin_file???, declared with attribute warn_unused_result
>
> So add two checks to get rid of 'em.
>
> Signed-off-by: Liu Yuan <[email protected]>
> ---
> drivers/video/udlfb.c | 15 ++++++++++++---
> 1 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
> index 68041d9..55d6de6 100644
> --- a/drivers/video/udlfb.c
> +++ b/drivers/video/udlfb.c
> @@ -1586,10 +1586,19 @@ static int dlfb_usb_probe(struct usb_interface *interface,
> goto error;
> }
>
> - for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++)
> - device_create_file(info->dev, &fb_device_attrs[i]);
> + for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) {
> + retval = device_create_file(info->dev, &fb_device_attrs[i]);
> + if (retval) {
> + pr_err("device_create_file failed %d\n", retval);
> + goto error;
> + }
> + }
>
> - device_create_bin_file(info->dev, &edid_attr);
> + retval = device_create_bin_file(info->dev, &edid_attr);
> + if (retval) {
> + pr_err("device_create_bin_file failed %d\n", retval);
> + goto error;
> + }
>

While this will get rid of the warnings, it doesn't take care of cleaning
up the created files in the error case..

2011-04-18 10:42:23

by Liu Yuan

Subject: Re: [PATCH] video, udlfb: Fix two build warning about 'ignoring return value'

Ah, thanks for pointing it out. I'll prepare v2 patch for it.

Thanks,
Yuan

On Mon, Apr 18, 2011 at 4:46 PM, Paul Mundt <[email protected]> wrote:
> On Thu, Apr 14, 2011 at 04:17:50PM +0800, Liu Yuan wrote:
>> Build warning:
>> ...
>> drivers/video/udlfb.c:1590: warning: ignoring return value of ???device_create_file???, declared with attribute warn_unused_result
>> drivers/video/udlfb.c:1592: warning: ignoring return value of ???device_create_bin_file???, declared with attribute warn_unused_result
>>
>> So add two checks to get rid of 'em.
>>
>> Signed-off-by: Liu Yuan <[email protected]>
>> ---
>>  drivers/video/udlfb.c |   15 ++++++++++++---
>>  1 files changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
>> index 68041d9..55d6de6 100644
>> --- a/drivers/video/udlfb.c
>> +++ b/drivers/video/udlfb.c
>> @@ -1586,10 +1586,19 @@ static int dlfb_usb_probe(struct usb_interface *interface,
>>               goto error;
>>       }
>>
>> -     for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++)
>> -             device_create_file(info->dev, &fb_device_attrs[i]);
>> +     for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) {
>> +             retval = device_create_file(info->dev, &fb_device_attrs[i]);
>> +             if (retval) {
>> +                     pr_err("device_create_file failed %d\n", retval);
>> +                     goto error;
>> +             }
>> +     }
>>
>> -     device_create_bin_file(info->dev, &edid_attr);
>> +     retval = device_create_bin_file(info->dev, &edid_attr);
>> +     if (retval) {
>> +             pr_err("device_create_bin_file failed %d\n", retval);
>> +             goto error;
>> +     }
>>
>
> While this will get rid of the warnings, it doesn't take care of cleaning
> up the created files in the error case..
>