2011-04-19 19:42:26

by Bob Tracy

[permalink] [raw]
Subject: [BUG] DMA_ERROR_CODE undefined in radeon_gart.c

Attempted to build 2.6.39-rc4 on an Alpha and got the following error:

CC [M] drivers/gpu/drm/radeon/radeon_gart.o
drivers/gpu/drm/radeon/radeon_gart.c: In function 'radeon_gart_bind':
drivers/gpu/drm/radeon/radeon_gart.c:186: error: 'DMA_ERROR_CODE' undeclared (first use in this function)
drivers/gpu/drm/radeon/radeon_gart.c:186: error: (Each undeclared identifier is reported only once
drivers/gpu/drm/radeon/radeon_gart.c:186: error: for each function it appears in.)
make[4]: *** [drivers/gpu/drm/radeon/radeon_gart.o] Error 1
make[3]: *** [drivers/gpu/drm/radeon] Error 2
make[2]: *** [drivers/gpu/drm] Error 2
make[1]: *** [drivers/gpu] Error 2
make: *** [drivers] Error 2

It appears that "DMA_ERROR_CODE" is currently defined for several
architectures in "arch/*/include/asm/dma-mapping.h", but not for "alpha".

--
------------------------------------------------------------------------
Bob Tracy | "Every normal man must be tempted at times to spit
[email protected] | upon his hands, hoist the black flag, and begin
| slitting throats." -- H.L. Mencken
------------------------------------------------------------------------


2011-04-19 20:04:53

by Stratos Psomadakis

[permalink] [raw]
Subject: Re: [BUG] DMA_ERROR_CODE undefined in radeon_gart.c

On 19/04/2011 10:42 μμ, Bob Tracy wrote:
> Attempted to build 2.6.39-rc4 on an Alpha and got the following error:
>
> CC [M] drivers/gpu/drm/radeon/radeon_gart.o
> drivers/gpu/drm/radeon/radeon_gart.c: In function 'radeon_gart_bind':
> drivers/gpu/drm/radeon/radeon_gart.c:186: error: 'DMA_ERROR_CODE' undeclared (first use in this function)
> drivers/gpu/drm/radeon/radeon_gart.c:186: error: (Each undeclared identifier is reported only once
> drivers/gpu/drm/radeon/radeon_gart.c:186: error: for each function it appears in.)
> make[4]: *** [drivers/gpu/drm/radeon/radeon_gart.o] Error 1
> make[3]: *** [drivers/gpu/drm/radeon] Error 2
> make[2]: *** [drivers/gpu/drm] Error 2
> make[1]: *** [drivers/gpu] Error 2
> make: *** [drivers] Error 2
>
> It appears that "DMA_ERROR_CODE" is currently defined for several
> architectures in "arch/*/include/asm/dma-mapping.h", but not for "alpha"
Similar issue in this discussion [1].
They solved it by replacing DMA_ERROR_CODE with dma_mapping_error().
Probably this can work here too.

--
Stratos Psomadakis
<[email protected]>

2011-04-19 20:07:14

by Stratos Psomadakis

[permalink] [raw]
Subject: Re: [BUG] DMA_ERROR_CODE undefined in radeon_gart.c

On 19/04/2011 11:04 μμ, Stratos Psomadakis wrote:
> On 19/04/2011 10:42 μμ, Bob Tracy wrote:
>> Attempted to build 2.6.39-rc4 on an Alpha and got the following error:
>>
>> CC [M] drivers/gpu/drm/radeon/radeon_gart.o
>> drivers/gpu/drm/radeon/radeon_gart.c: In function 'radeon_gart_bind':
>> drivers/gpu/drm/radeon/radeon_gart.c:186: error: 'DMA_ERROR_CODE' undeclared (first use in this function)
>> drivers/gpu/drm/radeon/radeon_gart.c:186: error: (Each undeclared identifier is reported only once
>> drivers/gpu/drm/radeon/radeon_gart.c:186: error: for each function it appears in.)
>> make[4]: *** [drivers/gpu/drm/radeon/radeon_gart.o] Error 1
>> make[3]: *** [drivers/gpu/drm/radeon] Error 2
>> make[2]: *** [drivers/gpu/drm] Error 2
>> make[1]: *** [drivers/gpu] Error 2
>> make: *** [drivers] Error 2
>>
>> It appears that "DMA_ERROR_CODE" is currently defined for several
>> architectures in "arch/*/include/asm/dma-mapping.h", but not for "alpha"
> Similar issue in this discussion [1].
> They solved it by replacing DMA_ERROR_CODE with dma_mapping_error(). [2]
> Probably this can work here too
[1] http://lkml.org/lkml/2010/3/11/261
[2] http://git.infradead.org/mtd-2.6.git/commitdiff/0c82d3ce

--
Stratos Psomadakis
<[email protected]>