2011-04-21 22:06:06

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the final tree (battery tree related)

---

Hi Anton,

After merging the final tree, today's linux-next build (s390 allyesconfig)
failed like this:

drivers/built-in.o: In function `max8903_remove':
drivers/power/max8903_charger.c:355: undefined reference to `free_irq'
drivers/power/max8903_charger.c:357: undefined reference to `free_irq'
drivers/power/max8903_charger.c:359: undefined reference to `free_irq'

Caused by commit b14a9ccc1ddd ("power_supply: Add driver for MAX8903
charger"). This driver needs some Kconfig dependency.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

---

Attachments:

(No filename) (596.00 B)
(No filename) (490.00 B)
Download all attachments

2011-04-21 23:27:11

by Anton Vorontsov

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (battery tree related)

---

Hi Stephen,

On Fri, Apr 22, 2011 at 08:05:55AM +1000, Stephen Rothwell wrote:
> Hi Anton,
>
> After merging the final tree, today's linux-next build (s390 allyesconfig)
> failed like this:
>
> drivers/built-in.o: In function `max8903_remove':
> drivers/power/max8903_charger.c:355: undefined reference to `free_irq'
> drivers/power/max8903_charger.c:357: undefined reference to `free_irq'
> drivers/power/max8903_charger.c:359: undefined reference to `free_irq'

I added the following patch to the battery-2.6.git, so this should be
fixed now. Thanks!

commit 6f9efe76cb213e9b0dd89e465efaf9725f4bf492
Author: Anton Vorontsov <[email protected]>
Date: Fri Apr 22 03:08:22 2011 +0400

max8903_charger: Add GENERIC_HARDIRQS as a dependency (fixes S390 build)

S390 is special as it doesn't have IRQ lines, so these errors pop up:

drivers/built-in.o: In function 'max8903_remove':
drivers/power/max8903_charger.c:355: undefined reference to 'free_irq'
drivers/power/max8903_charger.c:357: undefined reference to 'free_irq'
drivers/power/max8903_charger.c:359: undefined reference to 'free_irq'

This commit fixes the issue by making the driver depend on
GENERIC_HARDIRQS feature.

Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Anton Vorontsov <[email protected]>

diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 1f50ebc..cc019c9 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -205,6 +205,7 @@ config CHARGER_ISP1704

config CHARGER_MAX8903
tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
+ depends on GENERIC_HARDIRQS
help
Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
The driver supports controlling charger-enable and current-limit