2011-04-25 20:24:11

by Willy Tarreau

Subject: [PATCH 054/173] acer-wmi: Fix capitalisation of GUID

2.6.27.59-stable review patch. If anyone has any objections, please let us know.

------------------

From: Matthew Garrett <[email protected]>

commit bbb706079abe955a9e3f208f541de97d99449236 upstream.

6AF4F258-B401-42fd-BE91-3D4AC2D7C0D3 needs to be
6AF4F258-B401-42FD-BE91-3D4AC2D7C0D3 to match the hardware alias.

Signed-off-by: Matthew Garrett <[email protected]>
Acked-by: Carlos Corbacho <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
drivers/platform/x86/acer-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/misc/acer-wmi.c
+++ b/drivers/misc/acer-wmi.c
@@ -90,7 +90,7 @@ struct acer_quirks {
*/
#define AMW0_GUID1 "67C3371D-95A3-4C37-BB61-DD47B491DAAB"
#define AMW0_GUID2 "431F16ED-0C2B-444C-B267-27DEB140CF9C"
-#define WMID_GUID1 "6AF4F258-B401-42fd-BE91-3D4AC2D7C0D3"
+#define WMID_GUID1 "6AF4F258-B401-42FD-BE91-3D4AC2D7C0D3"
#define WMID_GUID2 "95764E09-FB56-4e83-B31A-37761F60994A"

MODULE_ALIAS("wmi:67C3371D-95A3-4C37-BB61-DD47B491DAAB");

2011-04-25 22:00:22

by Carlos Corbacho

Subject: Re: [PATCH 054/173] acer-wmi: Fix capitalisation of GUID

On Monday 25 Apr 2011 21:03:26 Willy Tarreau wrote:
> 2.6.27.59-stable review patch. If anyone has any objections, please let us
> know.

Nack - this caused https://bugzilla.kernel.org/show_bug.cgi?id=32862

Either don't apply this patch, or you'll need to also apply the subsequent fix
up at the same time (I don't know if that's gone upstream yet?).

-Carlos

>
> ------------------
>
> From: Matthew Garrett <[email protected]>
>
> commit bbb706079abe955a9e3f208f541de97d99449236 upstream.
>
> 6AF4F258-B401-42fd-BE91-3D4AC2D7C0D3 needs to be
> 6AF4F258-B401-42FD-BE91-3D4AC2D7C0D3 to match the hardware alias.
>
> Signed-off-by: Matthew Garrett <[email protected]>
> Acked-by: Carlos Corbacho <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>
> ---
> drivers/platform/x86/acer-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/misc/acer-wmi.c
> +++ b/drivers/misc/acer-wmi.c
> @@ -90,7 +90,7 @@ struct acer_quirks {
> */
> #define AMW0_GUID1 "67C3371D-95A3-4C37-BB61-DD47B491DAAB"
> #define AMW0_GUID2 "431F16ED-0C2B-444C-B267-27DEB140CF9C"
> -#define WMID_GUID1 "6AF4F258-B401-42fd-BE91-3D4AC2D7C0D3"
> +#define WMID_GUID1 "6AF4F258-B401-42FD-BE91-3D4AC2D7C0D3"
> #define WMID_GUID2 "95764E09-FB56-4e83-B31A-37761F60994A"
>
> MODULE_ALIAS("wmi:67C3371D-95A3-4C37-BB61-DD47B491DAAB");

2011-04-25 22:44:48

by Willy Tarreau

Subject: Re: [stable] [PATCH 054/173] acer-wmi: Fix capitalisation of GUID

On Mon, Apr 25, 2011 at 11:00:13PM +0100, Carlos Corbacho wrote:
> On Monday 25 Apr 2011 21:03:26 Willy Tarreau wrote:
> > 2.6.27.59-stable review patch. If anyone has any objections, please let us
> > know.
>
> Nack - this caused https://bugzilla.kernel.org/show_bug.cgi?id=32862
>
> Either don't apply this patch, or you'll need to also apply the subsequent fix
> up at the same time (I don't know if that's gone upstream yet?).

Fine, I've removed it.

Thank you Carlos!
Willy