2011-05-01 15:35:04

by Axel Lin

Subject: [PATCH] hwmon: twl4030-madc-hwmon: Return proper error if hwmon_device_register fails

Signed-off-by: Axel Lin <[email protected]>
---
drivers/hwmon/twl4030-madc-hwmon.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/twl4030-madc-hwmon.c b/drivers/hwmon/twl4030-madc-hwmon.c
index de58191..5724074 100644
--- a/drivers/hwmon/twl4030-madc-hwmon.c
+++ b/drivers/hwmon/twl4030-madc-hwmon.c
@@ -98,7 +98,6 @@ static const struct attribute_group twl4030_madc_group = {
static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
{
int ret;
- int status;
struct device *hwmon;

ret = sysfs_create_group(&pdev->dev.kobj, &twl4030_madc_group);
@@ -107,7 +106,7 @@ static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
hwmon = hwmon_device_register(&pdev->dev);
if (IS_ERR(hwmon)) {
dev_err(&pdev->dev, "hwmon_device_register failed.\n");
- status = PTR_ERR(hwmon);
+ ret = PTR_ERR(hwmon);
goto err_reg;
}

--
1.7.1

2011-05-01 15:44:36

by Guenter Roeck

Subject: Re: [PATCH] hwmon: twl4030-madc-hwmon: Return proper error if hwmon_device_register fails

On Sun, May 01, 2011 at 11:34:55AM -0400, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>

Good catch. Applied.

Thanks,
Guenter