2011-05-04 15:38:18

by Kees Cook

Subject: [PATCH] iosched: remove redundant sprintf

After the anticipatory scheduler was dropped, there was no need to
special-case the request_module string. As such, drop the redundant
sprintf and stack variable.

Signed-off-by: Kees Cook <[email protected]>
---
block/elevator.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/block/elevator.c b/block/elevator.c
index 45ca1e3..2a0b653 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -155,13 +155,8 @@ static struct elevator_type *elevator_get(const char *name)

e = elevator_find(name);
if (!e) {
- char elv[ELV_NAME_MAX + strlen("-iosched")];
-
spin_unlock(&elv_list_lock);
-
- snprintf(elv, sizeof(elv), "%s-iosched", name);
-
- request_module("%s", elv);
+ request_module("%s-iosched", name);
spin_lock(&elv_list_lock);
e = elevator_find(name);
}
--
1.7.4.1

--
Kees Cook
Ubuntu Security Team

2011-05-06 00:02:45

by Jens Axboe

Subject: Re: [PATCH] iosched: remove redundant sprintf

On 2011-05-04 09:38, Kees Cook wrote:
> After the anticipatory scheduler was dropped, there was no need to
> special-case the request_module string. As such, drop the redundant
> sprintf and stack variable.

Thanks, applied to for-2.6.40/core

--
Jens Axboe