Hi,
I wanted to send some patches, but checkpatch always tells me that they arent
clean and that I should fix them... but I am sure that the checkpatch.pl is
wrong.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ERROR: need consistent spacing around '*' (ctx:WxV)
#70: FILE: abc.h:70:
+ struct xyz __rcu *bar;
^
CHECK: spinlock_t definition without comment
#92: FILE: abc.h:92:
+ spinlock_t foo; /* protects: bar, foobar, barfoo, kaazaa, flupflup, fafafa,
total: 1 errors, 0 warnings, 1 checks, 1337 lines checked
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I am quite sure that the spacing should not be "struct xyz __rcu * bar" and
that the thing behind "spinlock_t foo;" is a comment.
Should I fix my patches or should checkpatch.pl be fixed?
--
Emil Langrock
Emil Langrock <[email protected]> writes:
>
> Should I fix my patches or should checkpatch.pl be fixed?
Since your patches are fine, checkpatch.pl should be fixed of course. I
generally ignore bogus messages.
-Andi
--
[email protected] -- Speaking for myself only