2011-05-10 02:50:57

by jiaweiwei

[permalink] [raw]
Subject: [PATCH]Add Maintainer for MAINTAINERS file for us

From: Harry Wei <[email protected]>

As our kernel is bigger and bigger, maintainers are more and more.
Maintainers add themselves into the MAINTAINERS file, which may add
without alphabetical order. This may be harmful to our management.
I'd like to maintain this file for us. The patch is below.

Signed-off-by: Harry Wei <[email protected]>
---
MAINTAINERS | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 16a5c5f..af39897 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2197,10 +2197,12 @@ F: drivers/acpi/dock.c

DOCUMENTATION
M: Randy Dunlap <[email protected]>
+M: Harry Wei <[email protected]>
L: [email protected]
T: quilt oss.oracle.com/~rdunlap/kernel-doc-patches/current/
S: Maintained
F: Documentation/
+F: MAINTAINERS

DOUBLETALK DRIVER
M: "James R. Van Zandt" <[email protected]>
--
1.7.0.4


2011-05-10 03:11:30

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH]Add Maintainer for MAINTAINERS file for us

On Tue, 2011-05-10 at 10:50 +0800, Harry Wei wrote:
> I'd like to maintain this file for us. The patch is below.

Knock yourself out, but I think this won't
be too valuable.

I suggest you setup a git tree and create a
separate MAINTAINERS section entry and not use
the existing DOCUMENTATION section entry.

Part of handling MAINTAINERS is understanding
that any tree where you collect entries will
not be authoritative. Lots of other MAINTAINERS
updates will occur outside of your tree and
nothing you do should hinder these updates.

One idea could be to separate all MAINTAINERS
sections into separate files in perhaps
a Maintainers directory. You would not ever
have to alphabetize sections again.

Maybe add a little script to the Makefile to
aggregate them together as well.

Another would be to add a '*...' pattern type
to the files to match files in any directory
or add a new filename only pattern akin to
'find -name "pattern"' rather than specify both
the directory and file together.

Update scripts/get_maintainer.pl too if you
add some new file pattern types please.

2011-05-10 04:52:08

by jiaweiwei

[permalink] [raw]
Subject: Re: [PATCH]Add Maintainer for MAINTAINERS file for us

On Mon, May 09, 2011 at 08:11:27PM -0700, Joe Perches wrote:
> On Tue, 2011-05-10 at 10:50 +0800, Harry Wei wrote:
> > I'd like to maintain this file for us. The patch is below.
>
> Knock yourself out, but I think this won't
> be too valuable.
The patch has been updatated below.
>
> I suggest you setup a git tree and create a
> separate MAINTAINERS section entry and not use
> the existing DOCUMENTATION section entry.
>
> Part of handling MAINTAINERS is understanding
> that any tree where you collect entries will
> not be authoritative. Lots of other MAINTAINERS
> updates will occur outside of your tree and
> nothing you do should hinder these updates.
>
> One idea could be to separate all MAINTAINERS
> sections into separate files in perhaps
> a Maintainers directory. You would not ever
> have to alphabetize sections again.
This may a little complex. Keeping just MAINTAINERS file
with alphabetical order is well for us.
I will also write a shell script for MAINTAINERS, which
can not only check whether it is in alphabetical order
but may also take orders for us.
The script is been programing by me and my friend.
When it is okay, i will patch for kernel.
>
> Maybe add a little script to the Makefile to
> aggregate them together as well.
>
> Another would be to add a '*...' pattern type
> to the files to match files in any directory
> or add a new filename only pattern akin to
> 'find -name "pattern"' rather than specify both
> the directory and file together.
>
> Update scripts/get_maintainer.pl too if you
> add some new file pattern types please.

Signed-off-by: Harry Wei <[email protected]>
---
MAINTAINERS | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index af39897..629dd7c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4043,6 +4043,12 @@ S: Maintained
F: drivers/net/macvlan.c
F: include/linux/if_macvlan.h

+MAINTAINERS-FILE
+M: Harry Wei <[email protected]>
+L: [email protected]
+S: Maintained
+F: MAINTAINERS
+
MAN-PAGES: MANUAL PAGES FOR LINUX -- Sections 2, 3, 4, 5, and 7
M: Michael Kerrisk <[email protected]>
W: http://www.kernel.org/doc/man-pages
--
1.7.0.4

2011-05-10 05:15:53

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH]Add Maintainer for MAINTAINERS file for us

On Tue, 2011-05-10 at 12:51 +0800, Harry Wei wrote:
> On Mon, May 09, 2011 at 08:11:27PM -0700, Joe Perches wrote:
> > On Tue, 2011-05-10 at 10:50 +0800, Harry Wei wrote:
> > > I'd like to maintain this file for us. The patch is below.
> > Knock yourself out, but I think this won't
> > be too valuable.
> The patch has been updatated below.
[]
> This may a little complex. Keeping just MAINTAINERS file
> with alphabetical order is well for us.
> I will also write a shell script for MAINTAINERS, which
> can not only check whether it is in alphabetical order
> but may also take orders for us.
> The script is been programing by me and my friend.
> When it is okay, i will patch for kernel.

I believe that's been done before.

http://lkml.org/lkml/2011/2/11/330

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> +MAINTAINERS-FILE
> +M: Harry Wei <[email protected]>
> +L: [email protected]
> +S: Maintained
> +F: MAINTAINERS

I think using the linux-doc mailing list for
MAINTAINERS isn't good.

2011-05-10 10:18:16

by jiaweiwei

[permalink] [raw]
Subject: Re: [PATCH]Add Maintainer for MAINTAINERS file for us

On Mon, May 09, 2011 at 10:15:50PM -0700, Joe Perches wrote:
> On Tue, 2011-05-10 at 12:51 +0800, Harry Wei wrote:
> > When it is okay, i will patch for kernel.
>
> I believe that's been done before.
>
> http://lkml.org/lkml/2011/2/11/330
That's great. I am so sorry i ignored that
patch. I will neaten this patch and take alphabetical
orders for MAINTAINERS. Then patch for them.
Thanks, Joe ;)
>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > +MAINTAINERS-FILE
> > +M: Harry Wei <[email protected]>
> > +L: [email protected]
> > +S: Maintained
> > +F: MAINTAINERS
>
> I think using the linux-doc mailing list for
> MAINTAINERS isn't good.
Hmmm, maybe you are right. So i patch below.
I think the default ML, LKML, is okay for
MAINTAINERS file, isn't it?

Signed-off-by: Harry Wei <[email protected]>
---
MAINTAINERS | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a471159..fb771aa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4048,6 +4048,12 @@ S: Maintained
F: drivers/net/macvlan.c
F: include/linux/if_macvlan.h

+MAINTAINERS FILE
+M: Harry Wei <[email protected]>
+L: [email protected]
+S: Maintained
+F: MAINTAINERS
+
MAN-PAGES: MANUAL PAGES FOR LINUX -- Sections 2, 3, 4, 5, and 7
M: Michael Kerrisk <[email protected]>
W: http://www.kernel.org/doc/man-pages
--
1.7.0.4