From: Tao Ma <[email protected]>
credits isn't a parameter for jbd2_journal_get_write_access and
jbd2_journal_get_undo_access. So remove the corresponding comments.
Cc: Jan Kara <[email protected]>
Cc: Randy Dunlap <[email protected]>
Signed-off-by: Tao Ma <[email protected]>
---
fs/jbd2/transaction.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 05fa77a..0a82612 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -813,7 +813,6 @@ out:
* int jbd2_journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update.
* @handle: transaction to add buffer modifications to
* @bh: bh to be used for metadata writes
- * @credits: variable that will receive credits for the buffer
*
* Returns an error code or 0 on success.
*
@@ -931,7 +930,6 @@ out:
* non-rewindable consequences
* @handle: transaction
* @bh: buffer to undo
- * @credits: store the number of taken credits here (if not NULL)
*
* Sometimes there is a need to distinguish between metadata which has
* been committed to disk and that which has not. The ext3fs code uses
--
1.7.1
On Wed 11-05-11 22:18:41, Tao Ma wrote:
> From: Tao Ma <[email protected]>
>
> credits isn't a parameter for jbd2_journal_get_write_access and
> jbd2_journal_get_undo_access. So remove the corresponding comments.
>
> Cc: Jan Kara <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Signed-off-by: Tao Ma <[email protected]>
For JBD2 changes please CC also Ted Ts'o <[email protected]> since he is
merging JBD2 patches. The patch is fine. Thanks.
Honza
> ---
> fs/jbd2/transaction.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..0a82612 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -813,7 +813,6 @@ out:
> * int jbd2_journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update.
> * @handle: transaction to add buffer modifications to
> * @bh: bh to be used for metadata writes
> - * @credits: variable that will receive credits for the buffer
> *
> * Returns an error code or 0 on success.
> *
> @@ -931,7 +930,6 @@ out:
> * non-rewindable consequences
> * @handle: transaction
> * @bh: buffer to undo
> - * @credits: store the number of taken credits here (if not NULL)
> *
> * Sometimes there is a need to distinguish between metadata which has
> * been committed to disk and that which has not. The ext3fs code uses
> --
> 1.7.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR
On Wed, 11 May 2011 16:56:04 +0200 Jan Kara wrote:
> On Wed 11-05-11 22:18:41, Tao Ma wrote:
> > From: Tao Ma <[email protected]>
> >
> > credits isn't a parameter for jbd2_journal_get_write_access and
> > jbd2_journal_get_undo_access. So remove the corresponding comments.
> >
> > Cc: Jan Kara <[email protected]>
> > Cc: Randy Dunlap <[email protected]>
> > Signed-off-by: Tao Ma <[email protected]>
> For JBD2 changes please CC also Ted Ts'o <[email protected]> since he is
> merging JBD2 patches. The patch is fine. Thanks.
Yes, normally Ted should merge this patch, not me.
Ted, do you need to have it resent to you?
Thanks.
> Honza
> > ---
> > fs/jbd2/transaction.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> > index 05fa77a..0a82612 100644
> > --- a/fs/jbd2/transaction.c
> > +++ b/fs/jbd2/transaction.c
> > @@ -813,7 +813,6 @@ out:
> > * int jbd2_journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update.
> > * @handle: transaction to add buffer modifications to
> > * @bh: bh to be used for metadata writes
> > - * @credits: variable that will receive credits for the buffer
> > *
> > * Returns an error code or 0 on success.
> > *
> > @@ -931,7 +930,6 @@ out:
> > * non-rewindable consequences
> > * @handle: transaction
> > * @bh: buffer to undo
> > - * @credits: store the number of taken credits here (if not NULL)
> > *
> > * Sometimes there is a need to distinguish between metadata which has
> > * been committed to disk and that which has not. The ext3fs code uses
> > --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***