2011-04-28 18:49:38

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ARM: ELF: Define new core note type for VFP registers

On Wed, Apr 13, 2011 at 10:56:36AM +0100, Dave Martin wrote:
> The VFP registers are not currently included in coredumps,
> and there's no existing note type where they can sensibly be
> included, so this patch defines a dedicated note type for them.

This probably wants to be copied to LKML (added).

> Signed-off-by: Dave Martin <[email protected]>
> Acked-by: Will Deacon <[email protected]>
> ---
> include/linux/elf.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/elf.h b/include/linux/elf.h
> index 4d60801..110821c 100644
> --- a/include/linux/elf.h
> +++ b/include/linux/elf.h
> @@ -395,6 +395,7 @@ typedef struct elf64_shdr {
> #define NT_S390_CTRS 0x304 /* s390 control registers */
> #define NT_S390_PREFIX 0x305 /* s390 prefix register */
> #define NT_S390_LAST_BREAK 0x306 /* s390 breaking event address */
> +#define NT_ARM_VFP 0x400 /* ARM VFP/NEON registers */
>
>
> /* Note header in a PT_NOTE section */
> --
> 1.7.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


2011-05-03 09:37:24

by Dave Martin

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ARM: ELF: Define new core note type for VFP registers

On Thu, Apr 28, 2011 at 07:49:25PM +0100, Russell King - ARM Linux wrote:
> On Wed, Apr 13, 2011 at 10:56:36AM +0100, Dave Martin wrote:
> > The VFP registers are not currently included in coredumps,
> > and there's no existing note type where they can sensibly be
> > included, so this patch defines a dedicated note type for them.
>
> This probably wants to be copied to LKML (added).

Good point-- thanks.

---Dave

>
> > Signed-off-by: Dave Martin <[email protected]>
> > Acked-by: Will Deacon <[email protected]>
> > ---
> > include/linux/elf.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/elf.h b/include/linux/elf.h
> > index 4d60801..110821c 100644
> > --- a/include/linux/elf.h
> > +++ b/include/linux/elf.h
> > @@ -395,6 +395,7 @@ typedef struct elf64_shdr {
> > #define NT_S390_CTRS 0x304 /* s390 control registers */
> > #define NT_S390_PREFIX 0x305 /* s390 prefix register */
> > #define NT_S390_LAST_BREAK 0x306 /* s390 breaking event address */
> > +#define NT_ARM_VFP 0x400 /* ARM VFP/NEON registers */
> >
> >
> > /* Note header in a PT_NOTE section */
> > --
> > 1.7.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2011-05-12 09:14:15

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ARM: ELF: Define new core note type for VFP registers

On Tue, May 03, 2011 at 10:36:59AM +0100, Dave Martin wrote:
> On Thu, Apr 28, 2011 at 07:49:25PM +0100, Russell King - ARM Linux wrote:
> > On Wed, Apr 13, 2011 at 10:56:36AM +0100, Dave Martin wrote:
> > > The VFP registers are not currently included in coredumps,
> > > and there's no existing note type where they can sensibly be
> > > included, so this patch defines a dedicated note type for them.
> >
> > This probably wants to be copied to LKML (added).
>
> Good point-- thanks.

What news on this?

2011-05-13 06:59:22

by Dave Martin

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ARM: ELF: Define new core note type for VFP registers

On Thu, May 12, 2011 at 10:14:00AM +0100, Russell King - ARM Linux wrote:
> On Tue, May 03, 2011 at 10:36:59AM +0100, Dave Martin wrote:
> > On Thu, Apr 28, 2011 at 07:49:25PM +0100, Russell King - ARM Linux wrote:
> > > On Wed, Apr 13, 2011 at 10:56:36AM +0100, Dave Martin wrote:
> > > > The VFP registers are not currently included in coredumps,
> > > > and there's no existing note type where they can sensibly be
> > > > included, so this patch defines a dedicated note type for them.
> > >
> > > This probably wants to be copied to LKML (added).
> >
> > Good point-- thanks.
>
> What news on this?

None whatsoever. Do you think I need to push harder for feedback?

---Dave

2011-05-13 07:29:56

by Nicolas Pitre

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ARM: ELF: Define new core note type for VFP registers

On Fri, 13 May 2011, Dave Martin wrote:

> On Thu, May 12, 2011 at 10:14:00AM +0100, Russell King - ARM Linux wrote:
> > On Tue, May 03, 2011 at 10:36:59AM +0100, Dave Martin wrote:
> > > On Thu, Apr 28, 2011 at 07:49:25PM +0100, Russell King - ARM Linux wrote:
> > > > On Wed, Apr 13, 2011 at 10:56:36AM +0100, Dave Martin wrote:
> > > > > The VFP registers are not currently included in coredumps,
> > > > > and there's no existing note type where they can sensibly be
> > > > > included, so this patch defines a dedicated note type for them.
> > > >
> > > > This probably wants to be copied to LKML (added).
> > >
> > > Good point-- thanks.
> >
> > What news on this?
>
> None whatsoever. Do you think I need to push harder for feedback?

I think that the patch should just be merged. If someone had a problem
with this, we would have heard about it by now.


Nicolas

2011-05-14 20:34:18

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ARM: ELF: Define new core note type for VFP registers

On Friday 13 May 2011, Nicolas Pitre wrote:
> On Fri, 13 May 2011, Dave Martin wrote:
>
> > On Thu, May 12, 2011 at 10:14:00AM +0100, Russell King - ARM Linux wrote:
> > > On Tue, May 03, 2011 at 10:36:59AM +0100, Dave Martin wrote:
> > > > On Thu, Apr 28, 2011 at 07:49:25PM +0100, Russell King - ARM Linux wrote:
> > > > > On Wed, Apr 13, 2011 at 10:56:36AM +0100, Dave Martin wrote:
> > > > > > The VFP registers are not currently included in coredumps,
> > > > > > and there's no existing note type where they can sensibly be
> > > > > > included, so this patch defines a dedicated note type for them.
> > > > >
> > > > > This probably wants to be copied to LKML (added).
> > > >
> > > > Good point-- thanks.
> > >
> > > What news on this?
> >
> > None whatsoever. Do you think I need to push harder for feedback?
>
> I think that the patch should just be merged. If someone had a problem
> with this, we would have heard about it by now.
>

Agreed. Uli and other toolchain people are waiting for this to get merged,
so we can put the ABI into gdb releases. It's definitely useful, and I couldn't
find anything wrong with it (but don't have much experience with ptrace).

Arnd