2011-05-19 12:37:08

by Eduardo Silva

Subject: [PATCH 1/2] gconfig: enable rules hint for main treeviews

Due to the large amount of rows in the treeviews, is difficult to
match columns with rows, setting the rules hint to 'true' allows the
treeview to alternate background colors in the rows making the data
more readable.

Signed-off-by: Eduardo Silva <[email protected]>
---
scripts/kconfig/gconf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 4558961..0c8db7d 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -253,7 +253,7 @@ void init_left_tree(void)

gtk_tree_view_set_model(view, model1);
gtk_tree_view_set_headers_visible(view, TRUE);
- gtk_tree_view_set_rules_hint(view, FALSE);
+ gtk_tree_view_set_rules_hint(view, TRUE);

column = gtk_tree_view_column_new();
gtk_tree_view_append_column(view, column);
@@ -298,7 +298,7 @@ void init_right_tree(void)

gtk_tree_view_set_model(view, model2);
gtk_tree_view_set_headers_visible(view, TRUE);
- gtk_tree_view_set_rules_hint(view, FALSE);
+ gtk_tree_view_set_rules_hint(view, TRUE);

column = gtk_tree_view_column_new();
gtk_tree_view_append_column(view, column);
--
1.7.4.1

2011-05-19 16:13:27

by Randy Dunlap

Subject: Re: [PATCH 1/2] gconfig: enable rules hint for main treeviews

On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:

> Due to the large amount of rows in the treeviews, is difficult to
> match columns with rows, setting the rules hint to 'true' allows the
> treeview to alternate background colors in the rows making the data
> more readable.
>
> Signed-off-by: Eduardo Silva <[email protected]>

Tested-by: Randy Dunlap <[email protected]>

Nice. Thanks.


> ---
> scripts/kconfig/gconf.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 4558961..0c8db7d 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -253,7 +253,7 @@ void init_left_tree(void)
>
> gtk_tree_view_set_model(view, model1);
> gtk_tree_view_set_headers_visible(view, TRUE);
> - gtk_tree_view_set_rules_hint(view, FALSE);
> + gtk_tree_view_set_rules_hint(view, TRUE);
>
> column = gtk_tree_view_column_new();
> gtk_tree_view_append_column(view, column);
> @@ -298,7 +298,7 @@ void init_right_tree(void)
>
> gtk_tree_view_set_model(view, model2);
> gtk_tree_view_set_headers_visible(view, TRUE);
> - gtk_tree_view_set_rules_hint(view, FALSE);
> + gtk_tree_view_set_rules_hint(view, TRUE);
>
> column = gtk_tree_view_column_new();
> gtk_tree_view_append_column(view, column);
> --

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2011-05-24 13:55:32

by Michal Marek

Subject: Re: [PATCH 1/2] gconfig: enable rules hint for main treeviews

On Thu, May 19, 2011 at 09:13:09AM -0700, Randy Dunlap wrote:
> On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:
>
> > Due to the large amount of rows in the treeviews, is difficult to
> > match columns with rows, setting the rules hint to 'true' allows the
> > treeview to alternate background colors in the rows making the data
> > more readable.
> >
> > Signed-off-by: Eduardo Silva <[email protected]>
>
> Tested-by: Randy Dunlap <[email protected]>
>
> Nice. Thanks.

Applied, thanks.

Michal