2011-05-25 00:04:36

by Nicolas Kaiser

Subject: [PATCH] staging: rts_pstor: use bitwise operator instead of logical one

Looks like a typo?

Signed-off-by: Nicolas Kaiser <[email protected]>
---
drivers/staging/rts_pstor/sd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
index bddb031..cdae497 100644
--- a/drivers/staging/rts_pstor/sd.c
+++ b/drivers/staging/rts_pstor/sd.c
@@ -2328,7 +2328,7 @@ Switch_Fail:

retval = sd_send_cmd_get_rsp(chip, IO_SEND_OP_COND, 0, SD_RSP_TYPE_R4, rsp, 5);
if (retval == STATUS_SUCCESS) {
- int func_num = (rsp[1] >> 4) && 0x07;
+ int func_num = (rsp[1] >> 4) & 0x07;
if (func_num) {
RTSX_DEBUGP("SD_IO card (Function number: %d)!\n", func_num);
chip->sd_io = 1;
--
1.7.5.rc3

2011-05-25 18:38:32

by Peter Huewe

Subject: Re: [PATCH] staging: rts_pstor: use bitwise operator instead of logical one

Am Mittwoch 25 Mai 2011, 02:03:02 schrieb Nicolas Kaiser:
> Looks like a typo?
>
> Signed-off-by: Nicolas Kaiser <[email protected]>
I think so, too.

Reviewed-by: Peter Huewe <[email protected]>