2011-04-05 15:01:18

by Michal Marek

Subject: [PATCH 26/34] dlm: Drop __TIME__ usage

The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Cc: Christine Caulfield <[email protected]>
Cc: David Teigland <[email protected]>
Cc: [email protected]
Signed-off-by: Michal Marek <[email protected]>
---
fs/dlm/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/dlm/main.c b/fs/dlm/main.c
index b80e0aa..5a59efa 100644
--- a/fs/dlm/main.c
+++ b/fs/dlm/main.c
@@ -50,7 +50,7 @@ static int __init init_dlm(void)
if (error)
goto out_netlink;

- printk("DLM (built %s %s) installed\n", __DATE__, __TIME__);
+ printk("DLM installed\n");

return 0;

--
1.7.4.1

2011-05-25 20:46:15

by Michal Marek

Subject: Re: [PATCH 26/34] dlm: Drop __TIME__ usage

Dne 5.4.2011 16:59, Michal Marek napsal(a):
> The kernel already prints its build timestamp during boot, no need to
> repeat it in random drivers and produce different object files each
> time.
>
> Cc: Christine Caulfield <[email protected]>
> Cc: David Teigland <[email protected]>
> Cc: [email protected]
> Signed-off-by: Michal Marek <[email protected]>
> ---
> fs/dlm/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Hi,

I don't see this patch in today's linux-next. Any objection against me
applying it to the kbuild-2.6.git repository?

Thanks,
Michal
>
> diff --git a/fs/dlm/main.c b/fs/dlm/main.c
> index b80e0aa..5a59efa 100644
> --- a/fs/dlm/main.c
> +++ b/fs/dlm/main.c
> @@ -50,7 +50,7 @@ static int __init init_dlm(void)
> if (error)
> goto out_netlink;
>
> - printk("DLM (built %s %s) installed\n", __DATE__, __TIME__);
> + printk("DLM installed\n");
>
> return 0;
>

2011-05-25 20:48:05

by David Teigland

Subject: Re: [PATCH 26/34] dlm: Drop __TIME__ usage

On Wed, May 25, 2011 at 10:47:16PM +0200, Michal Marek wrote:
> Dne 5.4.2011 16:59, Michal Marek napsal(a):
> > The kernel already prints its build timestamp during boot, no need to
> > repeat it in random drivers and produce different object files each
> > time.
> >
> > Cc: Christine Caulfield <[email protected]>
> > Cc: David Teigland <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Michal Marek <[email protected]>
> > ---
> > fs/dlm/main.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Hi,
>
> I don't see this patch in today's linux-next. Any objection against me
> applying it to the kbuild-2.6.git repository?

No, please do.
Thanks,
Dave