2011-05-25 00:38:00

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning in Linus' tree

---

Hi Greg,

In Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
produced this warning:

drivers/tty/serial/8250_pci.c:1457: warning: initialization from incompatible pointer type

Introduced by commit d9a0fbfd7bc5 ("serial: 8250_pci: add support for
Cronyx Omega PCI multiserial board").

Sorry that I didn't notice this earlier.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

---

Attachments:

(No filename) (446.00 B)
(No filename) (490.00 B)
Download all attachments

2011-05-26 07:14:53

by Greg KH

[permalink] [raw]

Subject: Re: linux-next: build warning in Linus' tree

---

On Wed, May 25, 2011 at 10:37:40AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> In Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
> produced this warning:
>
> drivers/tty/serial/8250_pci.c:1457: warning: initialization from incompatible pointer type
>
> Introduced by commit d9a0fbfd7bc5 ("serial: 8250_pci: add support for
> Cronyx Omega PCI multiserial board").
>
> Sorry that I didn't notice this earlier.

Thanks, I'll work on this.

greg k-h

2011-05-29 14:19:30

by Antony Pavlov

[permalink] [raw]

Subject: [PATCH] drivers/tty/serial/8250_pci.c: fix warning

---

Signed-off-by: Antony Pavlov <[email protected]>
---
drivers/tty/serial/8250_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/8250_pci.c b/drivers/tty/serial/8250_pci.c
index 4b4968a..78e98a5 100644
--- a/drivers/tty/serial/8250_pci.c
+++ b/drivers/tty/serial/8250_pci.c
@@ -973,7 +973,7 @@ ce4100_serial_setup(struct serial_private *priv,

static int
pci_omegapci_setup(struct serial_private *priv,
- struct pciserial_board *board,
+ const struct pciserial_board *board,
struct uart_port *port, int idx)
{
return setup_port(priv, port, 2, idx * 8, 0);
--
1.7.1