Remove unknown escape sequence \i in idle_setup.
Signed-off-by: Rohit Yadav <[email protected]>
---
arch/x86/kernel/process.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 426a5b6..ed2da29 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -642,7 +642,7 @@ static int __init idle_setup(char *str)
boot_option_idle_override = IDLE_POLL;
} else if (!strcmp(str, "mwait")) {
boot_option_idle_override = IDLE_FORCE_MWAIT;
- WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+ WARN_ONCE(1, "idle=mwait\" will be removed in 2012\"\n");
} else if (!strcmp(str, "halt")) {
/*
* When the boot option of idle=halt is added, halt is
--
1.7.4.1
On Mon, 30 May 2011 23:00:29 +0530, Rohit Yadav said:
> Remove unknown escape sequence \i in idle_setup.
> - WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> + WARN_ONCE(1, "idle=mwait\" will be removed in 2012\"\n");
I think what was *intended* was:
WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");
> I think what was *intended* was:
>
> WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");
Sure, anyway it was just an exercise, writing and submitting my first
Linux kernel patch.
Attached: New patch.
On Mon, 30 May 2011 23:28:47 +0530, Rohit Yadav said:
> Attached: New patch.
Still needs help:
> Remove unknown escape sequence \i in idle_setup.
> - WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> + WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");
Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or
similar. You should explain *what* the patch does (fix the quotes) and *why*
(because it's broken and won't compile).
On Mon, May 30, 2011 at 02:11:39PM -0400, [email protected] wrote:
> On Mon, 30 May 2011 23:28:47 +0530, Rohit Yadav said:
>
> > Attached: New patch.
>
> Still needs help:
>
> > Remove unknown escape sequence \i in idle_setup.
>
> > - WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> > + WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");
>
> Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or
> similar. You should explain *what* the patch does (fix the quotes) and *why*
> (because it's broken and won't compile).
Yep, all valid points. Another one would be to search whether this got
already fixed before wasting effort:
http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580
But it's not like there's nothing else that needs fixing in Linux. I'd
suggest using the new 'make W=' (do 'make help' for more info) build
option to build single objects and have gcc do more extensive checks.
Some of them actually are valid and need fixing.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
> Yep, all valid points. Another one would be to search whether this got
> already fixed before wasting effort:
>
> http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580
What is the best way to search if something got fixed? There are
plenty of repositories at git.kernel.org
I'm using this one:
http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Thanks.
On Tue, 31 May 2011 01:22:54 +0530 Rohit Yadav wrote:
> > Yep, all valid points. Another one would be to search whether this got
> > already fixed before wasting effort:
> >
> > http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580
>
> What is the best way to search if something got fixed? There are
> plenty of repositories at git.kernel.org
> I'm using this one:
> http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
There are > 100 git trees, so just pick a few, like acpi, tip, arm, etc.,
and check them (I wouldn't expect anyone to check _all_ of them).
Or you could check mailing list archives: see here:
http://marc.info/?l=linux-kernel&m=130675351609350&w=2
It would be good IMO if -tip had a commits mailing list like
stable and -mm and mainline do.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Mon, May 30, 2011 at 03:52:54PM -0400, Rohit Yadav wrote:
> > Yep, all valid points. Another one would be to search whether this got
> > already fixed before wasting effort:
> >
> > http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580
>
> What is the best way to search if something got fixed? There are
> plenty of repositories at git.kernel.org
> I'm using this one:
> http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Well, you either subscribe to lkml and search in your archives for it
or use your favourite search engine - they're usu. indexing lkml pretty
fast.
For example, google already indexed your mail I'm replying to and
returns it as the first result:
http://www.google.com/search?q=rohit+yadav+if+something+got+fixed
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
On Mon, May 30, 2011 at 01:00:32PM -0700, Randy Dunlap wrote:
> It would be good IMO if -tip had a commits mailing list like
> stable and -mm and mainline do.
There is one: http://www.spinics.net/lists/linux-tip-commits/
--
Regards/Gruss,
Boris.
On Tue, 31 May 2011, Rohit Yadav wrote:
> > Yep, all valid points. Another one would be to search whether this got
> > already fixed before wasting effort:
> >
> > http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580
>
> What is the best way to search if something got fixed? There are
> plenty of repositories at git.kernel.org
> I'm using this one:
> http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
>
Checking linux-next is usually a good idea:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=summary
--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.