Using __test_and_{set,clear}_bit_le() with ignoring its return value
can be replaced with __{set,clear}_bit_le().
Signed-off-by: Akinobu Mita <[email protected]>
Cc: Joel Becker <[email protected]>
Cc: Mark Fasheh <[email protected]>
Cc: [email protected]
---
fs/ocfs2/ocfs2.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h
index 4092858..bcde467 100644
--- a/fs/ocfs2/ocfs2.h
+++ b/fs/ocfs2/ocfs2.h
@@ -836,13 +836,13 @@ static inline unsigned int ocfs2_clusters_to_megabytes(struct super_block *sb,
static inline void _ocfs2_set_bit(unsigned int bit, unsigned long *bitmap)
{
- __test_and_set_bit_le(bit, bitmap);
+ __set_bit_le(bit, bitmap);
}
#define ocfs2_set_bit(bit, addr) _ocfs2_set_bit((bit), (unsigned long *)(addr))
static inline void _ocfs2_clear_bit(unsigned int bit, unsigned long *bitmap)
{
- __test_and_clear_bit_le(bit, bitmap);
+ __clear_bit_le(bit, bitmap);
}
#define ocfs2_clear_bit(bit, addr) _ocfs2_clear_bit((bit), (unsigned long *)(addr))
--
1.7.4.4
On Mon, May 30, 2011 at 09:58:05PM +0900, Akinobu Mita wrote:
> Using __test_and_{set,clear}_bit_le() with ignoring its return value
> can be replaced with __{set,clear}_bit_le().
>
> Signed-off-by: Akinobu Mita <[email protected]>
> Cc: Joel Becker <[email protected]>
> Cc: Mark Fasheh <[email protected]>
> Cc: [email protected]
Looks reasonable to me...
Signed-off-by: Mark Fasheh <[email protected]>
Joel?
--Mark
--
Mark Fasheh
On Tue, May 31, 2011 at 03:57:13PM -0700, Mark Fasheh wrote:
> On Mon, May 30, 2011 at 09:58:05PM +0900, Akinobu Mita wrote:
> > Using __test_and_{set,clear}_bit_le() with ignoring its return value
> > can be replaced with __{set,clear}_bit_le().
> >
> > Signed-off-by: Akinobu Mita <[email protected]>
> > Cc: Joel Becker <[email protected]>
> > Cc: Mark Fasheh <[email protected]>
> > Cc: [email protected]
>
> Looks reasonable to me...
>
> Signed-off-by: Mark Fasheh <[email protected]>
>
> Joel?
No argument here. Akinobu, do you want me to send it with ocfs2
fixes, or are you going to push it along?
Acked-by: Joel Becker <[email protected]>
Joel
--
"Lately I've been talking in my sleep.
Can't imagine what I'd have to say.
Except my world will be right
When love comes back my way."
http://www.jlbec.org/
[email protected]
> ? ? ? ?No argument here. ?Akinobu, do you want me to send it with ocfs2
> fixes, or are you going to push it along?
>
> Acked-by: Joel Becker <[email protected]>
Thanks. Please add it to ocfs2 tree.
On Mon, May 30, 2011 at 09:58:05PM +0900, Akinobu Mita wrote:
> Using __test_and_{set,clear}_bit_le() with ignoring its return value
> can be replaced with __{set,clear}_bit_le().
>
> Signed-off-by: Akinobu Mita <[email protected]>
> Cc: Joel Becker <[email protected]>
> Cc: Mark Fasheh <[email protected]>
> Cc: [email protected]
This patch is now in the 'fixes' branch of ocfs2.git.
Joel
--
"But then she looks me in the eye
And says, 'We're going to last forever,'
And man you know I can't begin to doubt it.
Cause it just feels so good and so free and so right,
I know we ain't never going to change our minds about it, Hey!
Here comes my girl."
http://www.jlbec.org/
[email protected]