2011-06-02 17:15:29

by Hartley Sweeten

[permalink] [raw]
Subject: [PATCH] gpio: Samsung: make Kconfig options def_bool

The Samsung GPIO drivers are always built-in when the relevant
platform is selected.  Change the Kconfig symbol to def_bool y
dependant on the platform.

Signed-off-by: H Hartley Sweeten <[email protected]>
Acked-by: Kyungmin Park <[email protected]>
Cc: Grant Likely <[email protected]>

---

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 18c0b31..2e3cd11 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -87,32 +87,20 @@ config GPIO_IT8761E
Say yes here to support GPIO functionality of IT8761E super I/O chip.

config GPIO_EXYNOS4
- bool "Samsung Exynos4 GPIO library support"
- default y
- depends on ARM && CPU_EXYNOS4210
- help
- Say yes here to support Samsung Exynos4 series SoCs GPIO library
+ def_bool y
+ depends on CPU_EXYNOS4210

config GPIO_PLAT_SAMSUNG
- bool "Samsung SoCs GPIO library support"
- default y
- depends on ARM && SAMSUNG_GPIOLIB_4BIT
- help
- Say yes here to support Samsung SoCs GPIO library
+ def_bool y
+ depends on SAMSUNG_GPIOLIB_4BIT

config GPIO_S5PC100
- bool "Samsung S5PC100 GPIO library support"
- default y
- depends on ARM && CPU_S5PC100
- help
- Say yes here to support Samsung S5PC100 SoCs GPIO library
+ def_bool y
+ depends on CPU_S5PC100

config GPIO_S5PV210
- bool "Samsung S5PV210/S5PC110 GPIO library support"
- default y
- depends on ARM && CPU_S5PV210
- help
- Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
+ def_bool y
+ depends on CPU_S5PV210

config GPIO_PL061
bool "PrimeCell PL061 GPIO support"


2011-06-03 18:25:47

by Grant Likely

[permalink] [raw]
Subject: Re: [PATCH] gpio: Samsung: make Kconfig options def_bool

On Thu, Jun 02, 2011 at 10:14:58AM -0700, H Hartley Sweeten wrote:
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected. ?Change the Kconfig symbol to def_bool y
> dependant on the platform.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Acked-by: Kyungmin Park <[email protected]>
> Cc: Grant Likely <[email protected]>

Patch doesn't apply on mainline. Linus already fixed up some stuff.

g.

>
> ---
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 18c0b31..2e3cd11 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
> Say yes here to support GPIO functionality of IT8761E super I/O chip.
>
> config GPIO_EXYNOS4
> - bool "Samsung Exynos4 GPIO library support"
> - default y
> - depends on ARM && CPU_EXYNOS4210
> - help
> - Say yes here to support Samsung Exynos4 series SoCs GPIO library
> + def_bool y
> + depends on CPU_EXYNOS4210
>
> config GPIO_PLAT_SAMSUNG
> - bool "Samsung SoCs GPIO library support"
> - default y
> - depends on ARM && SAMSUNG_GPIOLIB_4BIT
> - help
> - Say yes here to support Samsung SoCs GPIO library
> + def_bool y
> + depends on SAMSUNG_GPIOLIB_4BIT
>
> config GPIO_S5PC100
> - bool "Samsung S5PC100 GPIO library support"
> - default y
> - depends on ARM && CPU_S5PC100
> - help
> - Say yes here to support Samsung S5PC100 SoCs GPIO library
> + def_bool y
> + depends on CPU_S5PC100
>
> config GPIO_S5PV210
> - bool "Samsung S5PV210/S5PC110 GPIO library support"
> - default y
> - depends on ARM && CPU_S5PV210
> - help
> - Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> + def_bool y
> + depends on CPU_S5PV210
>
> config GPIO_PL061
> bool "PrimeCell PL061 GPIO support"

2011-06-03 18:32:52

by Hartley Sweeten

[permalink] [raw]
Subject: RE: [PATCH] gpio: Samsung: make Kconfig options def_bool

The Samsung GPIO drivers are always built-in when the relevant
platform is selected. ?Change the Kconfig symbol to def_bool y
dependant on the platform.

Signed-off-by: H Hartley Sweeten <[email protected]>
Acked-by: Kyungmin Park <[email protected]>
Cc: Grant Likely <[email protected]>

---

v2: updated based on mainline

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 4a7f631..2967002 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -87,32 +87,20 @@ config GPIO_IT8761E
Say yes here to support GPIO functionality of IT8761E super I/O chip.

config GPIO_EXYNOS4
- bool "Samsung Exynos4 GPIO library support"
- default y if CPU_EXYNOS4210
- depends on ARM
- help
- Say yes here to support Samsung Exynos4 series SoCs GPIO library
+ def_bool y
+ depends on CPU_EXYNOS4210

config GPIO_PLAT_SAMSUNG
- bool "Samsung SoCs GPIO library support"
- default y if SAMSUNG_GPIOLIB_4BIT
- depends on ARM
- help
- Say yes here to support Samsung SoCs GPIO library
+ def_bool y
+ depends on SAMSUNG_GPIOLIB_4BIT

config GPIO_S5PC100
- bool "Samsung S5PC100 GPIO library support"
- default y if CPU_S5PC100
- depends on ARM
- help
- Say yes here to support Samsung S5PC100 SoCs GPIO library
+ def_bool y
+ depends on CPU_S5PC100

config GPIO_S5PV210
- bool "Samsung S5PV210/S5PC110 GPIO library support"
- default y if CPU_S5PV210
- depends on ARM
- help
- Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
+ def_bool y
+ depends on CPU_S5PV210

config GPIO_PL061
bool "PrimeCell PL061 GPIO support"

2011-06-03 18:35:46

by Grant Likely

[permalink] [raw]
Subject: Re: [PATCH] gpio: Samsung: make Kconfig options def_bool

On Fri, Jun 03, 2011 at 01:32:41PM -0500, H Hartley Sweeten wrote:
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected. ?Change the Kconfig symbol to def_bool y
> dependant on the platform.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Acked-by: Kyungmin Park <[email protected]>
> Cc: Grant Likely <[email protected]>

Applied, thanks.

g.

>
> ---
>
> v2: updated based on mainline
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 4a7f631..2967002 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
> Say yes here to support GPIO functionality of IT8761E super I/O chip.
>
> config GPIO_EXYNOS4
> - bool "Samsung Exynos4 GPIO library support"
> - default y if CPU_EXYNOS4210
> - depends on ARM
> - help
> - Say yes here to support Samsung Exynos4 series SoCs GPIO library
> + def_bool y
> + depends on CPU_EXYNOS4210
>
> config GPIO_PLAT_SAMSUNG
> - bool "Samsung SoCs GPIO library support"
> - default y if SAMSUNG_GPIOLIB_4BIT
> - depends on ARM
> - help
> - Say yes here to support Samsung SoCs GPIO library
> + def_bool y
> + depends on SAMSUNG_GPIOLIB_4BIT
>
> config GPIO_S5PC100
> - bool "Samsung S5PC100 GPIO library support"
> - default y if CPU_S5PC100
> - depends on ARM
> - help
> - Say yes here to support Samsung S5PC100 SoCs GPIO library
> + def_bool y
> + depends on CPU_S5PC100
>
> config GPIO_S5PV210
> - bool "Samsung S5PV210/S5PC110 GPIO library support"
> - default y if CPU_S5PV210
> - depends on ARM
> - help
> - Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> + def_bool y
> + depends on CPU_S5PV210
>
> config GPIO_PL061
> bool "PrimeCell PL061 GPIO support"