2011-06-06 00:32:24

by Greg Dietsche

Subject: [PATCH] savage: remove unecessary if statement

the code always returns ret regardless, so if(ret) check is unecessary.

Signed-off-by: Greg Dietsche <[email protected]>
---
drivers/gpu/drm/savage/savage_bci.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index bf5f83e..cb1ee4e 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
_DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
&dev_priv->aperture);
- if (ret)
- return ret;
-
return ret;
}

--
1.7.2.5

2011-06-06 10:55:42

by Nicolas Kaiser

Subject: Re: [PATCH] savage: remove unecessary if statement

* Greg Dietsche <[email protected]>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/

>
> Signed-off-by: Greg Dietsche <[email protected]>
Reviewed-by: Nicolas Kaiser <[email protected]>

Best regards,
Nicolas Kaiser
> ---
> drivers/gpu/drm/savage/savage_bci.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
> ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
> _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
> &dev_priv->aperture);
> - if (ret)
> - return ret;
> -
> return ret;
> }
>

2011-06-13 14:40:49

by Greg Dietsche

Subject: [PATCH v2] savage: remove unnecessary if statement

the code always returns ret regardless, so if(ret) check is unnecessary.

v2: fixed up the spelling.

Signed-off-by: Greg Dietsche <[email protected]>
Reviewed-by: Nicolas Kaiser <[email protected]>

---
drivers/gpu/drm/savage/savage_bci.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index bf5f83e..cb1ee4e 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
_DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
&dev_priv->aperture);
- if (ret)
- return ret;
-
return ret;
}

--
1.7.2.5