2011-05-30 20:09:55

by Németh Márton

Subject: [PATCH] usbip: change match_busid() to local function

From: Márton Németh <[email protected]>

The function match_busid() is only referenced in the stub_main.c so it can be changed
to static. This will remove the following warning when compiling with "make W=1 ...":

* drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’

Signed-off-by: Márton Németh <[email protected]>
---
diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
index e9085d6..fc5b829 100644
--- a/drivers/staging/usbip/stub_main.c
+++ b/drivers/staging/usbip/stub_main.c
@@ -37,7 +37,7 @@ struct kmem_cache *stub_priv_cache;
static struct bus_id_priv busid_table[MAX_BUSID];
static spinlock_t busid_table_lock;

-int match_busid(const char *busid)
+static int match_busid(const char *busid)
{
int i;

2011-06-07 21:35:10

by Greg KH

Subject: Re: [PATCH] usbip: change match_busid() to local function

On Mon, May 30, 2011 at 10:09:39PM +0200, Németh Márton wrote:
> From: Márton Németh <[email protected]>
>
> The function match_busid() is only referenced in the stub_main.c so it can be changed
> to static. This will remove the following warning when compiling with "make W=1 ...":
>
> * drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’
>
> Signed-off-by: Márton Németh <[email protected]>

This no longer applies, care to redo it against the next linux-next tree
that comes out?

thanks,

greg k-h

2011-06-08 04:53:59

by Németh Márton

Subject: Re: [PATCH] usbip: change match_busid() to local function

From: Márton Németh <[email protected]>

The function match_busid() is only referenced in the stub_main.c so it can be changed
to static. This will remove the following warning when compiling with "make W=1 ...":
* drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’

Signed-off-by: Márton Németh <[email protected]>
---
diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
index e9085d6..fc5b829 100644
--- a/drivers/staging/usbip/stub_main.c
+++ b/drivers/staging/usbip/stub_main.c
@@ -37,7 +37,7 @@ struct kmem_cache *stub_priv_cache;
static struct bus_id_priv busid_table[MAX_BUSID];
static spinlock_t busid_table_lock;

-int match_busid(const char *busid)
+static int match_busid(const char *busid)
{
int i;

2011-06-08 05:05:28

by Németh Márton

Subject: Re: [PATCH] usbip: change match_busid() to local function

Forget it, this change is already there in the
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git ,
on staging-next branch. I just forget to switch the branch from master
after cloning the staging-2.6 repository.

Regards,

Márton Németh

Németh Márton wrote:
> From: Márton Németh <[email protected]>
>
> The function match_busid() is only referenced in the stub_main.c so it can be changed
> to static. This will remove the following warning when compiling with "make W=1 ...":
> * drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’
>
> Signed-off-by: Márton Németh <[email protected]>
> ---
> diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
> index e9085d6..fc5b829 100644
> --- a/drivers/staging/usbip/stub_main.c
> +++ b/drivers/staging/usbip/stub_main.c
> @@ -37,7 +37,7 @@ struct kmem_cache *stub_priv_cache;
> static struct bus_id_priv busid_table[MAX_BUSID];
> static spinlock_t busid_table_lock;
>
> -int match_busid(const char *busid)
> +static int match_busid(const char *busid)
> {
> int i;
>
>