2011-06-10 16:08:41

by Hartley Sweeten

[permalink] [raw]
Subject: [PATCH] gpio/ep93xx: Add missing EP93XX_GPIO_PHYS_BASE define

The patch to convert of the ep93xx gpio driver to a platform_driver is
missing the define for the memory resource that is passed to the driver.

This is needed to prevent a build error.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Ryan Mallon <[email protected]>

---

Grant, can you pick this up in your tree to prevent the build error?

diff --git a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
index 9ac4d10..c4a7b84 100644
--- a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
+++ b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
@@ -98,6 +98,7 @@

#define EP93XX_SECURITY_BASE EP93XX_APB_IOMEM(0x00030000)

+#define EP93XX_GPIO_PHYS_BASE EP93XX_APB_PHYS(0x00040000)
#define EP93XX_GPIO_BASE EP93XX_APB_IOMEM(0x00040000)
#define EP93XX_GPIO_REG(x) (EP93XX_GPIO_BASE + (x))
#define EP93XX_GPIO_F_INT_STATUS EP93XX_GPIO_REG(0x5c)


2011-06-11 05:28:17

by Grant Likely

[permalink] [raw]
Subject: Re: [PATCH] gpio/ep93xx: Add missing EP93XX_GPIO_PHYS_BASE define

On Fri, Jun 10, 2011 at 09:08:17AM -0700, H Hartley Sweeten wrote:
> The patch to convert of the ep93xx gpio driver to a platform_driver is
> missing the define for the memory resource that is passed to the driver.
>
> This is needed to prevent a build error.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Grant Likely <[email protected]>
> Cc: Ryan Mallon <[email protected]>

Applied, thanks.

g.

>
> ---
>
> Grant, can you pick this up in your tree to prevent the build error?
>
> diff --git a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> index 9ac4d10..c4a7b84 100644
> --- a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> +++ b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> @@ -98,6 +98,7 @@
>
> #define EP93XX_SECURITY_BASE EP93XX_APB_IOMEM(0x00030000)
>
> +#define EP93XX_GPIO_PHYS_BASE EP93XX_APB_PHYS(0x00040000)
> #define EP93XX_GPIO_BASE EP93XX_APB_IOMEM(0x00040000)
> #define EP93XX_GPIO_REG(x) (EP93XX_GPIO_BASE + (x))
> #define EP93XX_GPIO_F_INT_STATUS EP93XX_GPIO_REG(0x5c)