2011-06-11 02:38:18

by jiaweiwei

[permalink] [raw]
Subject: [PATCH v2 0/4]Documentation/zh_CN: Remove messy code documentations and rebuild new documentations

From: Harry Wei <[email protected]>

There are two messy code documentations in our
Documentation/zh_CN/ directory. They are
Documentation/zh_CN/email-clients.txt &
Documentation/zh_CN/SubmitChecklist.
The following patches can fix them.

Harry Wei (4)
Documentation/zh_CN: remove messy code file email-clients.txt
Documentation/zh_CN: remove messy code file SubmitChecklist
Documentation/zh_CN: add new file email-clients.txt
Documentation/zh_CN: add new file SubmitChecklist

Thanks
Harry Wei


2011-06-11 20:14:36

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH v2 0/4]Documentation/zh_CN: Remove messy code documentations and rebuild new documentations

On Sat, Jun 11, 2011 at 10:37:52AM +0800, Harry Wei wrote:
> From: Harry Wei <[email protected]>
>
> There are two messy code documentations in our
> Documentation/zh_CN/ directory. They are
> Documentation/zh_CN/email-clients.txt &
> Documentation/zh_CN/SubmitChecklist.
> The following patches can fix them.
>
> Harry Wei (4)
> Documentation/zh_CN: remove messy code file email-clients.txt
> Documentation/zh_CN: remove messy code file SubmitChecklist
> Documentation/zh_CN: add new file email-clients.txt
> Documentation/zh_CN: add new file SubmitChecklist

Why are you deleting and then adding back the files? Why not just edit
them and change them in one single patch?

What made them "messy" in the first place?

greg k-h

2011-06-12 02:53:40

by jiaweiwei

[permalink] [raw]
Subject: Re: [PATCH v2 0/4]Documentation/zh_CN: Remove messy code documentations and rebuild new documentations

On Sat, Jun 11, 2011 at 01:05:13PM -0700, Greg KH wrote:
> On Sat, Jun 11, 2011 at 10:37:52AM +0800, Harry Wei wrote:
> > From: Harry Wei <[email protected]>
> >
> > There are two messy code documentations in our
> > Documentation/zh_CN/ directory. They are
> > Documentation/zh_CN/email-clients.txt &
> > Documentation/zh_CN/SubmitChecklist.
> > The following patches can fix them.
> >
> > Harry Wei (4)
> > Documentation/zh_CN: remove messy code file email-clients.txt
> > Documentation/zh_CN: remove messy code file SubmitChecklist
> > Documentation/zh_CN: add new file email-clients.txt
> > Documentation/zh_CN: add new file SubmitChecklist
>
> Why are you deleting and then adding back the files?
> Why not just edit them and change them in one single patch?
Hmmm..., what about two patches? One for editing and changing
email-clients.txt and the other one for editing and changing
SubmitChecklist.
> What made them "messy" in the first place?
Maybe it is something wrong with my mutt client. It can not
deal with Chinese characters. So i can only send them with
attachments now. So sorry for this. I have also fix my
mutt client, but it seems to be useless. I will try to fix
it later.

Thanks
Harry Wei

2011-06-12 05:32:47

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH v2 0/4]Documentation/zh_CN: Remove messy code documentations and rebuild new documentations

On Sun, Jun 12, 2011 at 10:53:21AM +0800, Harry Wei wrote:
> On Sat, Jun 11, 2011 at 01:05:13PM -0700, Greg KH wrote:
> > On Sat, Jun 11, 2011 at 10:37:52AM +0800, Harry Wei wrote:
> > > From: Harry Wei <[email protected]>
> > >
> > > There are two messy code documentations in our
> > > Documentation/zh_CN/ directory. They are
> > > Documentation/zh_CN/email-clients.txt &
> > > Documentation/zh_CN/SubmitChecklist.
> > > The following patches can fix them.
> > >
> > > Harry Wei (4)
> > > Documentation/zh_CN: remove messy code file email-clients.txt
> > > Documentation/zh_CN: remove messy code file SubmitChecklist
> > > Documentation/zh_CN: add new file email-clients.txt
> > > Documentation/zh_CN: add new file SubmitChecklist
> >
> > Why are you deleting and then adding back the files?
> > Why not just edit them and change them in one single patch?
> Hmmm..., what about two patches? One for editing and changing
> email-clients.txt and the other one for editing and changing
> SubmitChecklist.

That is fine, I'll queue them up in a few days.

greg k-h

2011-06-12 08:27:30

by jiaweiwei

[permalink] [raw]
Subject: Re: [PATCH v2 0/4]Documentation/zh_CN: Remove messy code documentations and rebuild new documentations

On Sat, Jun 11, 2011 at 10:32:15PM -0700, Greg KH wrote:
> > > Why are you deleting and then adding back the files?
> > > Why not just edit them and change them in one single patch?
> > Hmmm..., what about two patches? One for editing and changing
> > email-clients.txt and the other one for editing and changing
> > SubmitChecklist.
>
> That is fine, I'll queue them up in a few days.

Okay, that's great ;-)


Thanks
Harry Wei