2011-06-16 18:57:07

by Randy Dunlap

Subject: [PATCH] sound: fix lola section mismatch warnings

From: Randy Dunlap <[email protected]>

Fix section mismatch warnings in lola sound driver:

WARNING: sound/pci/lola/snd-lola.o(.text+0xda4): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_pcm()
The function lola_parse_tree() references
the function __devinit lola_init_pcm().
This is often because lola_parse_tree lacks a __devinit
annotation or the annotation of lola_init_pcm is wrong.

WARNING: sound/pci/lola/snd-lola.o(.text+0xdf5): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_pins()
The function lola_parse_tree() references
the function __devinit lola_init_pins().
This is often because lola_parse_tree lacks a __devinit
annotation or the annotation of lola_init_pins is wrong.

WARNING: sound/pci/lola/snd-lola.o(.text+0xe52): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_clock_widget()
The function lola_parse_tree() references
the function __devinit lola_init_clock_widget().
This is often because lola_parse_tree lacks a __devinit
annotation or the annotation of lola_init_clock_widget is wrong.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Takashi Iwai <[email protected]>
---
sound/pci/lola/lola.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-30-rc3.orig/sound/pci/lola/lola.c
+++ lnx-30-rc3/sound/pci/lola/lola.c
@@ -445,7 +445,7 @@ static void lola_reset_setups(struct lol
lola_setup_all_analog_gains(chip, PLAY, false); /* output, update */
}

-static int lola_parse_tree(struct lola *chip)
+static int __devinit lola_parse_tree(struct lola *chip)
{
unsigned int val;
int nid, err;

2011-06-16 19:00:18

by Takashi Iwai

Subject: Re: [PATCH] sound: fix lola section mismatch warnings

At Thu, 16 Jun 2011 11:56:46 -0700,
Randy Dunlap wrote:
>
> From: Randy Dunlap <[email protected]>
>
> Fix section mismatch warnings in lola sound driver:
>
> WARNING: sound/pci/lola/snd-lola.o(.text+0xda4): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_pcm()
> The function lola_parse_tree() references
> the function __devinit lola_init_pcm().
> This is often because lola_parse_tree lacks a __devinit
> annotation or the annotation of lola_init_pcm is wrong.
>
> WARNING: sound/pci/lola/snd-lola.o(.text+0xdf5): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_pins()
> The function lola_parse_tree() references
> the function __devinit lola_init_pins().
> This is often because lola_parse_tree lacks a __devinit
> annotation or the annotation of lola_init_pins is wrong.
>
> WARNING: sound/pci/lola/snd-lola.o(.text+0xe52): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_clock_widget()
> The function lola_parse_tree() references
> the function __devinit lola_init_clock_widget().
> This is often because lola_parse_tree lacks a __devinit
> annotation or the annotation of lola_init_clock_widget is wrong.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Takashi Iwai <[email protected]>

Thanks, but the same is already in sound git tree.


Takashi

> ---
> sound/pci/lola/lola.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-30-rc3.orig/sound/pci/lola/lola.c
> +++ lnx-30-rc3/sound/pci/lola/lola.c
> @@ -445,7 +445,7 @@ static void lola_reset_setups(struct lol
> lola_setup_all_analog_gains(chip, PLAY, false); /* output, update */
> }
>
> -static int lola_parse_tree(struct lola *chip)
> +static int __devinit lola_parse_tree(struct lola *chip)
> {
> unsigned int val;
> int nid, err;
>