Ingo,
please pull oprofile fixes for v3.0 (tip/perf/urgent):
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
Thanks,
-Robert
The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
Robert Richter (2):
oprofile, x86: Fix race in nmi handler while starting counters
oprofile, x86: Fix nmi-unsafe callgraph support
arch/x86/oprofile/backtrace.c | 56 ++++++++++++++++++++++++++++++++++------
arch/x86/oprofile/nmi_int.c | 14 +++++++---
2 files changed, 57 insertions(+), 13 deletions(-)
--
Advanced Micro Devices, Inc.
Operating System Research Center
Robert,
* Robert Richter <[email protected]> wrote:
> Ingo,
>
> please pull oprofile fixes for v3.0 (tip/perf/urgent):
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
>
> Thanks,
>
> -Robert
>
>
> The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
>
> Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
>
> are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
>
> Robert Richter (2):
> oprofile, x86: Fix race in nmi handler while starting counters
> oprofile, x86: Fix nmi-unsafe callgraph support
>
> arch/x86/oprofile/backtrace.c | 56 ++++++++++++++++++++++++++++++++++------
> arch/x86/oprofile/nmi_int.c | 14 +++++++---
> 2 files changed, 57 insertions(+), 13 deletions(-)
Since when has NMI callgraph support been broken?
Thanks,
Ingo
On 21.06.11 09:03:08, Ingo Molnar wrote:
>
> Robert,
>
> * Robert Richter <[email protected]> wrote:
>
> > Ingo,
> >
> > please pull oprofile fixes for v3.0 (tip/perf/urgent):
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> >
> > Thanks,
> >
> > -Robert
> >
> >
> > The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
> >
> > Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
> >
> > are available in the git repository at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> >
> > Robert Richter (2):
> > oprofile, x86: Fix race in nmi handler while starting counters
> > oprofile, x86: Fix nmi-unsafe callgraph support
> >
> > arch/x86/oprofile/backtrace.c | 56 ++++++++++++++++++++++++++++++++++------
> > arch/x86/oprofile/nmi_int.c | 14 +++++++---
> > 2 files changed, 57 insertions(+), 13 deletions(-)
>
> Since when has NMI callgraph support been broken?
I think it never worked correct. But the patch can be backported
without conflicts/reworks only for .37 stable kernel. Do you rather
like to take it for v3.1?
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
* Robert Richter <[email protected]> wrote:
> On 21.06.11 09:03:08, Ingo Molnar wrote:
> >
> > Robert,
> >
> > * Robert Richter <[email protected]> wrote:
> >
> > > Ingo,
> > >
> > > please pull oprofile fixes for v3.0 (tip/perf/urgent):
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > >
> > > Thanks,
> > >
> > > -Robert
> > >
> > >
> > > The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
> > >
> > > Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
> > >
> > > are available in the git repository at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > >
> > > Robert Richter (2):
> > > oprofile, x86: Fix race in nmi handler while starting counters
> > > oprofile, x86: Fix nmi-unsafe callgraph support
> > >
> > > arch/x86/oprofile/backtrace.c | 56 ++++++++++++++++++++++++++++++++++------
> > > arch/x86/oprofile/nmi_int.c | 14 +++++++---
> > > 2 files changed, 57 insertions(+), 13 deletions(-)
> >
> > Since when has NMI callgraph support been broken?
>
> I think it never worked correct. But the patch can be backported
> without conflicts/reworks only for .37 stable kernel. Do you rather
> like to take it for v3.1?
Yeah, v3.1 would be fine - if it was broken for like 5-10 years then
it's not eligible for -rc5. The linecount is very high as well, it's
definitely not a oneliner fix ...
Thanks,
Ingo
On 21.06.11 16:18:40, Ingo Molnar wrote:
> > I think it never worked correct. But the patch can be backported
> > without conflicts/reworks only for .37 stable kernel. Do you rather
> > like to take it for v3.1?
>
> Yeah, v3.1 would be fine - if it was broken for like 5-10 years then
> it's not eligible for -rc5. The linecount is very high as well, it's
> definitely not a oneliner fix ...
Ingo,
I dropped this patch, there is only one fix now. Please pull again
from:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git for-tip
Thanks,
-Robert
The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git for-tip
Robert Richter (1):
oprofile, x86: Fix race in nmi handler while starting counters
arch/x86/oprofile/nmi_int.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
--
Advanced Micro Devices, Inc.
Operating System Research Center