2011-06-28 14:00:28

by Maxime Ripard

[permalink] [raw]
Subject: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci

The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
Force it thanks to DMI.

Signed-off-by: Maxime Ripard <[email protected]>
---
arch/x86/kernel/reboot.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 0c016f7..d712043 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -411,6 +411,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"),
},
},
+ { /* Handle problems with rebooting on the Latitude E6320. */
+ .callback = set_pci_reboot,
+ .ident = "Dell Latitude E6320",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
+ },
+ },
{ }
};

--
1.7.4.1


2011-06-28 17:43:29

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci

On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.

On which kernel versions?

--
Matthew Garrett | [email protected]

2011-06-28 19:35:55

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci

On 28/06/2011 19:41, Matthew Garrett wrote:
> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>
> On which kernel versions?

All the versions from 2.6.38 to 3.0-rc5.


--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

2011-06-28 19:53:22

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci

On 28/06/2011 21:35, Maxime Ripard wrote:
> On 28/06/2011 19:41, Matthew Garrett wrote:
>> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>>
>> On which kernel versions?
>
> All the versions from 2.6.38 to 3.0-rc5.

I am not saying this is a regression though. I just didn't test it with
an earlier kernel.


--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

2011-06-28 20:03:33

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci

On Tue, Jun 28, 2011 at 09:35:40PM +0200, Maxime Ripard wrote:
> On 28/06/2011 19:41, Matthew Garrett wrote:
> >On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
> >>The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
> >
> >On which kernel versions?
>
> All the versions from 2.6.38 to 3.0-rc5.

Could you provide the acpidump output for the system?

--
Matthew Garrett | [email protected]

2011-06-29 07:33:51

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci

On 28/06/2011 22:03, Matthew Garrett wrote:
> On Tue, Jun 28, 2011 at 09:35:40PM +0200, Maxime Ripard wrote:
>> On 28/06/2011 19:41, Matthew Garrett wrote:
>>> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>>>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>>>
>>> On which kernel versions?
>>
>> All the versions from 2.6.38 to 3.0-rc5.
>
> Could you provide the acpidump output for the system?
>

Sure, here it is :
http://free-electrons.com/~maxime/pub/acpidumb-e6320.log

--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com