2011-06-29 17:05:59

by Andres Salomon

[permalink] [raw]
Subject: Re: [PATCH 1/1] geode: Reflect mfgpt dependency on mfd.

Looks correct to me. It should probably be sent to Andrew to be queued
up.

Acked-by: Andres Salomon <[email protected]>

On Tue, 28 Jun 2011
22:00:09 -0600 Philip Prindeville <[email protected]> wrote:

> From: Philip A. Prindeville <[email protected]>
>
> As stated in drivers/mfd/cs5535-mfd.c, the mfd driver exposes the BARs
> which then make the GPIO, MFGPT, ACPI, etc. all visible to the system.
>
> This dependency needs to be reflected in Kconfig.
>
> Signed-off-by: Philip A. Prindeville <[email protected]>
> Acked-by: Alexandros C. Couloumbis <[email protected]>
> ---
> drivers/misc/Kconfig | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 4e349cd..3546474 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -245,8 +245,7 @@ config SGI_XP
>
> config CS5535_MFGPT
> tristate "CS5535/CS5536 Geode Multi-Function General Purpose
> Timer (MFGPT) support"
> - depends on PCI
> - depends on X86
> + depends on PCI && X86 && MFD_CS5535
> default n
> help
> This driver provides access to MFGPT functionality for
> other