2012-02-01 13:27:19

by Roland Stigge

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] LPC32xx: clock.c: USB PLL fix

Hi Wolfram,

Thanks for reviewing my patches! I collected (and applied) all your
suggestions and will re-post the series as a patch update for applying
to the mainline tree.

On 01/31/2012 11:34 AM, Wolfram Sang wrote:
> I remember we needed that fix back then as well, so I am tempted to
> ack it. However, I'd like to test it but USB is currently not
> available. Do you happen to have a USB fixing commit just to test
> (can be hackish)?

I'm posting this one separately (to be applied on top of all my and
your posted patches).

What do you think about mainline-integrating it?

Thanks in advance!


2012-02-02 16:49:42

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] LPC32xx: clock.c: USB PLL fix

Hi,

> Thanks for reviewing my patches! I collected (and applied) all your
> suggestions and will re-post the series as a patch update for applying
> to the mainline tree.

Yes, please repost this series with the updates. And without USB & MMC
updates. Those updates should be in later series, when we actually add
support for these devices.

> What do you think about mainline-integrating it?

See my comment there.

First step, I'd suggest: After you repost this series, I'll create a
branch with the relevant patches (defconfig, buildfixes, clock fixes)
and send a pull-request to Arnd/Olof. You can decide which issue you
want to tackle next. I'd think MMC or USB are more of the lower hanging
fruits, but I leave that to you.

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |


Attachments:
(No filename) (908.00 B)
signature.asc (198.00 B)
Digital signature
Download all attachments

2012-02-02 19:20:21

by Roland Stigge

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] LPC32xx: clock.c: USB PLL fix

Hi Wolfram,

On 02/02/2012 05:49 PM, Wolfram Sang wrote:
> Yes, please repost this series with the updates. And without USB &
> MMC updates. Those updates should be in later series, when we
> actually add support for these devices.

OK, reposting.

> First step, I'd suggest: After you repost this series, I'll create
> a branch with the relevant patches (defconfig, buildfixes, clock
> fixes) and send a pull-request to Arnd/Olof. You can decide which
> issue you want to tackle next. I'd think MMC or USB are more of the
> lower hanging fruits, but I leave that to you.

I'd then first repost the GPIO fixes I posted previously and then look
after USB if that's fine for you. :-)

Thanks,

Roland

2012-02-02 23:01:54

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] LPC32xx: clock.c: USB PLL fix


> I'd then first repost the GPIO fixes I posted previously and then look
> after USB if that's fine for you. :-)

Totally fine with me, it's all up to you :)

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |


Attachments:
(No filename) (314.00 B)
signature.asc (198.00 B)
Digital signature
Download all attachments