2012-02-14 03:30:41

by Axel Lin

Subject: [PATCH] mfd: Make pcf50633_write_block() return 0 on success

The callers of pcf50633_write_block assume pcf50633_write_block return 0 on
success, thus make it return 0 instead of the number of registers written on
success.

Currently pcf50633_write_block is called in drivers/mfd/pcf50633-irq.c and
drivers/rtc/rtc-pcf50633.c.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mfd/pcf50633-core.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index ff1a7e7..189c2f0 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -46,13 +46,7 @@ EXPORT_SYMBOL_GPL(pcf50633_read_block);
int pcf50633_write_block(struct pcf50633 *pcf , u8 reg,
int nr_regs, u8 *data)
{
- int ret;
-
- ret = regmap_raw_write(pcf->regmap, reg, data, nr_regs);
- if (ret != 0)
- return ret;
-
- return nr_regs;
+ return regmap_raw_write(pcf->regmap, reg, data, nr_regs);
}
EXPORT_SYMBOL_GPL(pcf50633_write_block);

--
1.7.5.4

2012-02-14 09:13:40

by Harald Welte

Subject: Re: [PATCH] mfd: Make pcf50633_write_block() return 0 on success

Hi Axel,

On Tue, Feb 14, 2012 at 11:30:31AM +0800, Axel Lin wrote:
> The callers of pcf50633_write_block assume pcf50633_write_block return 0 on
> success, thus make it return 0 instead of the number of registers written on
> success.

This change seems to make a lot of sense, thanks for spotting it.

Acked-by: Harald Welte <[email protected]>

--
- Harald Welte <[email protected]> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)

2012-02-23 15:34:11

by Samuel Ortiz

Subject: Re: [PATCH] mfd: Make pcf50633_write_block() return 0 on success

Hi Axel,

On Tue, Feb 14, 2012 at 11:30:31AM +0800, Axel Lin wrote:
> The callers of pcf50633_write_block assume pcf50633_write_block return 0 on
> success, thus make it return 0 instead of the number of registers written on
> success.
>
> Currently pcf50633_write_block is called in drivers/mfd/pcf50633-irq.c and
> drivers/rtc/rtc-pcf50633.c.
Applied as well, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/