2012-02-14 21:07:23

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] security: TOMOYO should clean policy files

From: Randy Dunlap <[email protected]>

TOMOYO creates some empty/default policy files during build.
It should remove them during 'make clean'.

I noticed that they were not being removed because the
"Creating ..." messages always occurred a maximum of one time
during 25 randconfig builds, so it was sometimes using the
files from a previous build (which is not a problem, but
still, 'make clean' should remove them).

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Kentaro Takeda <[email protected]>
Cc: Tetsuo Handa <[email protected]>
Cc: [email protected]
---
security/tomoyo/Makefile | 2 ++
1 file changed, 2 insertions(+)

--- linux-next-20120214.orig/security/tomoyo/Makefile
+++ linux-next-20120214/security/tomoyo/Makefile
@@ -46,3 +46,5 @@ $(obj)/builtin-policy.h: $(obj)/policy/p
@mv [email protected] $@

$(obj)/common.o: $(obj)/builtin-policy.h
+
+clean-dirs := $(objtree)/security/tomoyo/policy/


2012-02-15 12:36:41

by Tetsuo Handa

[permalink] [raw]
Subject: Re: [PATCH] security: TOMOYO should clean policy files

Randy Dunlap wrote:
> TOMOYO creates some empty/default policy files during build.
> It should remove them during 'make clean'.
>
> I noticed that they were not being removed because the
> "Creating ..." messages always occurred a maximum of one time
> during 25 randconfig builds, so it was sometimes using the
> files from a previous build (which is not a problem, but
> still, 'make clean' should remove them).

Thank you. But I prefer current behavior.

The content of automatically generated files depends on neither kernel config
nor architecture. They are static contents which are used when a user did not
explicitly supply contents. Therefore, I think we don't need to delete them by
'make clean'.