2012-02-21 10:08:50

by santosh nayak

Subject: [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT_MASK().

From: Santosh Nayak <[email protected]>

Use the macro DMA_BIT_MASK instead of the constant 0xffffffff

Signed-off-by: Santosh Nayak <[email protected]>
---
drivers/firewire/nosy.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
index 763626b..a7c4422 100644
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -36,7 +36,7 @@
#include <linux/timex.h>
#include <linux/uaccess.h>
#include <linux/wait.h>
-
+#include <linux/dma-mapping.h>
#include <linux/atomic.h>
#include <asm/byteorder.h>

@@ -536,7 +536,7 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused)
u32 p, end;
int ret, i;

- if (pci_set_dma_mask(dev, 0xffffffff)) {
+ if (pci_set_dma_mask(dev, DMA_BIT_MASK(32))) {
dev_err(&dev->dev,
"DMA address limits not supported for PCILynx hardware\n");
return -ENXIO;
--
1.7.4.4

2012-02-21 13:01:21

by Stefan Richter

Subject: Re: [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT_MASK().

On Feb 21 santosh nayak wrote:
> Use the macro DMA_BIT_MASK instead of the constant 0xffffffff
>
> Signed-off-by: Santosh Nayak <[email protected]>
> ---
> drivers/firewire/nosy.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
> index 763626b..a7c4422 100644
> --- a/drivers/firewire/nosy.c
> +++ b/drivers/firewire/nosy.c
> @@ -36,7 +36,7 @@
> #include <linux/timex.h>
> #include <linux/uaccess.h>
> #include <linux/wait.h>
> -
> +#include <linux/dma-mapping.h>
> #include <linux/atomic.h>
> #include <asm/byteorder.h>
>
> @@ -536,7 +536,7 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused)
> u32 p, end;
> int ret, i;
>
> - if (pci_set_dma_mask(dev, 0xffffffff)) {
> + if (pci_set_dma_mask(dev, DMA_BIT_MASK(32))) {
> dev_err(&dev->dev,
> "DMA address limits not supported for PCILynx hardware\n");
> return -ENXIO;

Thanks, I will commit it to linux1394.git soon.
--
Stefan Richter
-=====-===-- --=- =-=-=
http://arcgraph.de/sr/