2012-02-24 16:01:49

by Ben Myers

[permalink] [raw]
Subject:

Bcc:
Subject: Re: [PATCH] xfs: Use memset to initialize structure member.
Reply-To:
In-Reply-To: <20120224075354.GA3649@mwanda>

On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
> On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
> > From: Santosh Nayak <[email protected]>
> >
> > Sparse is giving following warning:
> > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
> >
>
> You could just do:
> struct xfs_bmalloca bma = {};

Santosh, this aggregate initializer seems cleaner than memset. Do you
mind resending the patch with Dan's suggestion?

Thanks for your contribution. ;)

-Ben