2012-02-24 19:28:08

by Randy Dunlap

Subject: [PATCH] security: fix ima kconfig warning

From: Randy Dunlap <[email protected]>

Fix IMA kconfig warning on non-X86 architectures:

warning: (IMA) selects TCG_TIS which has unmet direct dependencies
(TCG_TPM && X86)

But why do TCG_TIS and TCG_NSC depend on X86??

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: Geert Uytterhoeven <[email protected]>
Cc: Mimi Zohar <[email protected]>
Cc: James Morris <[email protected]>
---
No IMA/TPM builds have been tested with this change...

security/integrity/ima/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-33-rc4.orig/security/integrity/ima/Kconfig
+++ lnx-33-rc4/security/integrity/ima/Kconfig
@@ -10,7 +10,7 @@ config IMA
select CRYPTO_MD5
select CRYPTO_SHA1
select TCG_TPM if !S390 && !UML
- select TCG_TIS if TCG_TPM
+ select TCG_TIS if TCG_TPM && X86
help
The Trusted Computing Group(TCG) runtime Integrity
Measurement Architecture(IMA) maintains a list of hash

2012-02-27 20:31:56

by Rajiv Andrade

Subject: Re: [PATCH] security: fix ima kconfig warning

On Fri, 24 Feb 2012, Randy Dunlap wrote:

> From: Randy Dunlap <[email protected]>
>
> Fix IMA kconfig warning on non-X86 architectures:
>
> warning: (IMA) selects TCG_TIS which has unmet direct dependencies
> (TCG_TPM && X86)
>
> But why do TCG_TIS and TCG_NSC depend on X86??
>

These drivers only support the probing for TPM devices on this platform,
through PNP or a hardcoded address base.

Acked-by: Rajiv Andrade <[email protected]>

> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: Geert Uytterhoeven <[email protected]>
> Cc: Mimi Zohar <[email protected]>
> Cc: James Morris <[email protected]>
> ---
> No IMA/TPM builds have been tested with this change...
>
> security/integrity/ima/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-33-rc4.orig/security/integrity/ima/Kconfig
> +++ lnx-33-rc4/security/integrity/ima/Kconfig
> @@ -10,7 +10,7 @@ config IMA
> select CRYPTO_MD5
> select CRYPTO_SHA1
> select TCG_TPM if !S390 && !UML
> - select TCG_TIS if TCG_TPM
> + select TCG_TIS if TCG_TPM && X86
> help
> The Trusted Computing Group(TCG) runtime Integrity
> Measurement Architecture(IMA) maintains a list of hash
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
Rajiv Andrade
Security Development
IBM Linux Technology Center

2012-02-28 00:02:59

by James Morris

Subject: Re: [PATCH] security: fix ima kconfig warning

On Fri, 24 Feb 2012, Randy Dunlap wrote:

> From: Randy Dunlap <[email protected]>
>
> Fix IMA kconfig warning on non-X86 architectures:

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next


- James
--
James Morris
<[email protected]>