2012-05-02 15:47:43

by Joe Korty

[permalink] [raw]
Subject: checkpatch: forward declarations fix

Allow forward declarations of the form:

struct file_operations;

to exist without requiring the preceeding 'const'. In
any case C does not allow 'const' on forward declarations.

Signed-off-by: Joe Korty <[email protected]>

Index: linux/scripts/checkpatch.pl
===================================================================
--- linux.orig/scripts/checkpatch.pl 2012-05-02 10:29:03.000000000 -0400
+++ linux/scripts/checkpatch.pl 2012-05-02 10:38:45.000000000 -0400
@@ -3411,9 +3411,11 @@
wd_ops}x;
if ($line !~ /\bconst\b/ &&
$line =~ /\bstruct\s+($struct_ops)\b/) {
- WARN("CONST_STRUCT",
- "struct $1 should normally be const\n" .
- $herecurr);
+ if ($line !~ /struct\s+($struct_ops);/) {
+ WARN("CONST_STRUCT",
+ "struct $1 should normally be const\n" .
+ $herecurr);
+ }
}

# use of NR_CPUS is usually wrong