2012-05-03 00:57:24

by Hartley Sweeten

Subject: [PATCH] tty: mxser: local variables should not be exposed globally

The variable 'mxser_port_ops' is only referenced in this file and
should be marked static to prevent it from being exposed globally.

Quites the sparse warning:

warning: symbol 'mxser_port_ops' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>

---

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index c6f372d..90cc680 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -2326,7 +2326,7 @@ static const struct tty_operations mxser_ops = {
.get_icount = mxser_get_icount,
};

-struct tty_port_operations mxser_port_ops = {
+static struct tty_port_operations mxser_port_ops = {
.carrier_raised = mxser_carrier_raised,
.dtr_rts = mxser_dtr_rts,
.activate = mxser_activate,

2012-05-03 08:42:53

by Alan

Subject: Re: [PATCH] tty: mxser: local variables should not be exposed globally

On Wed, 2 May 2012 17:57:17 -0700
H Hartley Sweeten <[email protected]> wrote:

> The variable 'mxser_port_ops' is only referenced in this file and
> should be marked static to prevent it from being exposed globally.


Acked-by: Alan Cox <[email protected]>