2012-05-02 23:55:06

by Hartley Sweeten

Subject: [PATCH] watchdog: sp5100_tco.c: quiet sparse noise about using plain integer was NULL pointer

Pointers should not be compared to plain integers.
Quiets the sparse warning:
warning: Using plain integer as NULL pointer

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Wim Van Sebroeck <[email protected]>

---

diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c
index 59108e4..ae5e82c 100644
--- a/drivers/watchdog/sp5100_tco.c
+++ b/drivers/watchdog/sp5100_tco.c
@@ -313,7 +313,7 @@ static unsigned char __devinit sp5100_tco_setupdevice(void)
tcobase_phys = val;

tcobase = ioremap(val, SP5100_WDT_MEM_MAP_SIZE);
- if (tcobase == 0) {
+ if (!tcobase) {
pr_err("failed to get tcobase address\n");
goto unreg_mem_region;
}

2012-05-03 11:03:39

by Wim Van Sebroeck

Subject: Re: [PATCH] watchdog: sp5100_tco.c: quiet sparse noise about using plain integer was NULL pointer

Hi,

> Pointers should not be compared to plain integers.
> Quiets the sparse warning:
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>

Added to linux-watchdog-next.

Kind regards,
Wim.